Merged
Conversation
Partial fix for #1260 The `nginx` configuration for `test.dhall-lang.org` wasn't correctly checking the headers because the fully materialized configuration looked like this: ``` server { … server_name test.dhall-lang.org ; … location / { proxy_pass https://raw.githubusercontent.com; … rewrite ^/?$ https://store.dhall-lang.org/Prelude-v21.1.0 redire ct; rewrite ^/(v[^/]+)$ https://github.com/dhall-lang/dhall-lang/tre e/$1/Prelude redirect; rewrite ^/(v[^/]+)/(.*)$ /dhall-lang/dhall-lang/$1/Prelude/$2 br eak; rewrite ^/(.*)$ /dhall-lang/dhall-lang/v21.1.0/Prelude/$1 break; if ($http_test = "") { return 403; } } ``` … and the `rewrite` rules were taking precedence over the `http_test` check. This change fixes that by redoing the test such that only `test.dhall-lang.org/{foo,bar}` require the `Test` header and those two imports are used for the test instead. A side benefit of this change is that the test is now not as brittle (since it won't break if we change `Prelude/Bool/package.dhall`)
hagl
reviewed
Jan 8, 2022
… as caught by @hagl Co-authored-by: Harald Gliebe <harald.gliebe@gmail.com>
hagl
reviewed
Jan 9, 2022
… as caught by @hagl
hagl
reviewed
Jan 10, 2022
hagl
approved these changes
Jan 10, 2022
Contributor
hagl
left a comment
There was a problem hiding this comment.
There is one outdated comment, otherwise looks good to me
… as suggested by @hagl Co-authored-by: Harald Gliebe <harald.gliebe@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Partial fix for #1260
The
nginxconfiguration fortest.dhall-lang.orgwasn't correctlychecking the headers because the fully materialized configuration
looked like this:
… and the
rewriterules were taking precedence over thehttp_testcheck.This change fixes that by redoing the test such that only
test.dhall-lang.org/{foo,bar}require theTestheader and those twoimports are used for the test instead. A side benefit of this change is
that the test is now not as brittle (since it won't break if we
change
Prelude/Bool/package.dhall)