Add test for importing relative to the home directory#1250
Merged
Gabriella439 merged 2 commits intomasterfrom Dec 5, 2021
Merged
Add test for importing relative to the home directory#1250Gabriella439 merged 2 commits intomasterfrom
Gabriella439 merged 2 commits intomasterfrom
Conversation
Gabriella439
approved these changes
Dec 4, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The current test suite doesn't seem to cover the case where an import is relative to home:
~Well it does cover it for parsing, but that's it. The
dhall-rustimplementation had a bug when it came to resolving the home directory that went
uncaught for a while: Nadrieril/dhall-rust#224
Note: I am not sure about the environment variable for Windows and if it's
enough to mock the location of
~. Could someone using Windows check?