first arg is missing in beta-normalization of Natural/build#1244
Merged
Gabriella439 merged 2 commits intodhall-lang:masterfrom Dec 10, 2021
Merged
first arg is missing in beta-normalization of Natural/build#1244Gabriella439 merged 2 commits intodhall-lang:masterfrom
Gabriella439 merged 2 commits intodhall-lang:masterfrom
Conversation
First arg should be type Natural, then succ and zero. In dhall-haskell this is done here: https://github.com/dhall-lang/dhall-haskell/blob/235f38c8048c9a9fee7379d77fc55d179e0d107e/dhall/src/Dhall/Normalize.hs#L220
sjakobi
approved these changes
Dec 1, 2021
Collaborator
sjakobi
left a comment
There was a problem hiding this comment.
I was initially a bit skeptical, because the type argument seemed pointless on first sight. But the type quite clearly requires it, and the example in the Prelude helps illustrate it for me:
dhall-lang/Prelude/Natural/build.dhall
Lines 11 to 19 in 17762d5
Good catch! 👍
Contributor
|
Yeah, this change is definitely correct. The only reason we didn't catch it is because the code in question is not being exercised (yet) |
Gabriella439
approved these changes
Dec 1, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I think, I found a small bug in the specification of the beta-normalization.
The beta-normalization of Natural/build should apply
gtoNatural,succandzero.The first of these arguments is currently not provided. Compare with the dhall-haskell implementation: https://github.com/dhall-lang/dhall-haskell/blob/235f38c8048c9a9fee7379d77fc55d179e0d107e/dhall/src/Dhall/Normalize.hs#L220