Fix parent imports when resolving headers.dhall#1233
Merged
Gabriella439 merged 3 commits intomasterfrom Oct 29, 2021
Merged
Conversation
The motivation for this change is the discussion here: dhall-lang/dhall-haskell#2236 (comment) If we correctly set the parent import for the `headers.dhall` expression then the cyclic import detection will correctly reject loops induced by `headers.dhall` having transitive remote imports of its own.
6 tasks
sjakobi
reviewed
Oct 22, 2021
… based on a discussion with @sjakobi
sjakobi
approved these changes
Oct 22, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The motivation for this change is the discussion here:
dhall-lang/dhall-haskell#2236 (comment)
If we correctly set the parent import for the
headers.dhallexpression then the cyclic import detection will correctly reject
loops induced by
headers.dhallhaving transitive remote importsof its own.