Skip to content

Test changes for dhall-purescript#1190

Merged
Gabriella439 merged 6 commits intodhall-lang:masterfrom
MonoidMusician:ps-test-fixes
Jul 9, 2021
Merged

Test changes for dhall-purescript#1190
Gabriella439 merged 6 commits intodhall-lang:masterfrom
MonoidMusician:ps-test-fixes

Conversation

@MonoidMusician
Copy link
Copy Markdown
Collaborator

@MonoidMusician MonoidMusician commented Jun 30, 2021

There were some minor discrepancies that kept some of the tests from passing in my dhall-purescript implementation, including some alpha normalization differences that I previously worked around in the test suite: MonoidMusician/dhall-purescript@192d6b3

This is based on my interpretation of the standard/test spec, perhaps not all of these tweaks should actually be upstreamed.

@MonoidMusician
Use .dhall suffix for remoteSystems normalization test
a20745e 
To match the non-alpha-normalized result given in
tests/normalization/success/remoteSystemsB.dhall
@MonoidMusician
Leave lets in import successes
c808262 
Given that they appear at the top level, not in an import.
@MonoidMusician
Alpha-normalize headerForwardingB.dhall
fa1659b 
Since its import (Bool/package.dhall) contains imports
protected by integrity checks.
@MonoidMusician
Add variables to function type annotations in type-inference tests
af1fed0 
This is to allow implementations to either take the type from the
expression or from the annotation, without having to alpha-normalize
to see that the types match for the purposes of the test.
@MonoidMusician
Formatting
4c62e46
@MonoidMusician
Copy link
Copy Markdown
Collaborator Author

MonoidMusician commented Jun 30, 2021

I just checked with dhall-haskell and these changes do not seem to affect passage of the tests (if I'm doing it properly, that is …). I do get one test failure both at the latest dhall-lang and with my changes:

Dhall Tests
  import tests
    discover
      ./dhall-lang/tests/import/success/hashFromCacheA.dhall:                                                                  
Warning: Import integrity check failed

Expected hash:

↳ 618f785ce8f3930a9144398f576f0a992544b51212bc9108c31b4e670dc6ed21

Actual hash:

↳ ca2cb37e2ff08f1748be98e8eaf61598d93b25e2f716c8857303aa9028b86280

But that probably just means I am running the tests wrong (XDG_CACHE_HOME=dhall/dhall-lang/tests/import/cache stack test dhall or without XDG_CACHE_HOME set).

@Nadrieril
Copy link
Copy Markdown
Member

Nadrieril commented Jul 4, 2021

Excellent! Turns out I was mistakenly normalizing fully in import tests and hadn't noticed before

@Gabriella439 Gabriella439 merged commit acc5466 into dhall-lang:master Jul 9, 2021
@travisbrown travisbrown mentioned this pull request Jul 27, 2021
Open
@travisbrown
Copy link
Copy Markdown
Collaborator

travisbrown commented Jul 27, 2021

@MonoidMusician Are you also running the type-inference/success/prelude tests? When I updated Dhall for Java past this point I had to make some changes to make sure that import resolution alpha-normalizes the result when there's an integrity check, and now I'm seeing some of the Monoid tests fail.

@MonoidMusician
Copy link
Copy Markdown
Collaborator Author

MonoidMusician commented Jul 28, 2021

Ah no, I had to skip the prelude test since my implementation is inefficient, so I probably missed something there.

@travisbrown travisbrown mentioned this pull request Jul 28, 2021
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Gabriella439 Gabriella439 Gabriella439 approved these changes

@Nadrieril Nadrieril Nadrieril approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@MonoidMusician @Nadrieril @travisbrown @Gabriella439