Prelude: Escape XML text using the &…; method#1174
Merged
Gabriella439 merged 2 commits intomasterfrom May 20, 2021
Merged
Conversation
Gabriella439
approved these changes
May 13, 2021
fc8b65e to
03a8396
Compare
Author
|
I am not able to set the right hash on one of these files. |
Contributor
|
@ehmry: If you run |
Author
|
The hash is correct from my side. |
Contributor
|
@ehmry: Do you mean that you ran the script locally and it produced a different hash than the one that CI expects? |
Author
|
I can't run the script, I'm on aarch64 and something haskell is broken. I've set the hash to the output of |
Contributor
|
@ehmry: The main thing you need to change is this hash: diff --recursive ./Prelude.actual/XML/render ./Prelude.expected/XML/render
1c1
< ./render.dhall sha256:aff7efe61ce299381edca023e24bb5aaa0656c41bfa45dd705dab63519b7c5db
---
> ./render.dhall sha256:550c8900fe199b83d629181d53c646f2f9425d9c64670dabb30d28e95bfa4c75
builder for '/nix/store/a7l6ja91blpbymrznbki02wdkrx9agpa-prelude-lint.drv' failed with exit code 1 |
Escape special markup characters using the method described here: https://www.w3.org/TR/REC-xml/#syntax
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We need to be escaping
<in as<in XML text (I disovered this while writing an Atom feed generator).