Add Prelude.Text.{lower,upper}ASCII utilities#1164
Merged
Gabriella439 merged 8 commits intomasterfrom May 11, 2021
Merged
Conversation
Related to #631 In particular, this is based on the suggestion from: #631 (comment)
basile-henry
reviewed
May 4, 2021
Contributor
|
Wouldn't it make sense to also include |
Oops! 🙂 … as caught by @basile-henry Co-authored-by: Basile Henry <bjm.henry@gmail.com>
… as suggested by @ad-si
Prelude.Text.lowerASCII utilityPrelude.Text.{lower,upper}ASCII utilities
Collaborator
|
You might want to add a warning that decomposed unicode characters (base character + modifier diacritics) may be affected by case conversion: assert : lowerASCII "Á" ≡ "á"(I believe that is correct, but you should test!) |
ad-si
suggested changes
May 7, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Related to #631
In particular, this is based on the suggestion from:
#631 (comment)