Fix typo in re-escaping rule of multiline strings#1097
Merged
Gabriella439 merged 2 commits intodhall-lang:masterfrom Nov 11, 2020
Merged
Fix typo in re-escaping rule of multiline strings#1097Gabriella439 merged 2 commits intodhall-lang:masterfrom
Gabriella439 merged 2 commits intodhall-lang:masterfrom
Conversation
There seems to be a typo in the rule for the re-escaping of characters `\`, `$` and `"`. I guess the rule should add a leading backslash to escape the given character, otherwise it would just do nothing, and would be exactly the same as the following one about non-special characters.
Gabriella439
approved these changes
Nov 2, 2020
Contributor
|
@yannham: Thank you for fixing that! 🙂 |
Contributor
Author
|
Glad to help! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
There seems to be a typo in the rule for the re-escaping of characters
\,$and". I think the rule lacks the addition of a leading backslash to escape the given character, because currently it just preserves the original character at it is, and is exactly the same as the following rule for non-special characters.