Support reading test-specific environment from *ENV.dhall file#2268
Merged
Gabriella439 merged 4 commits intodhall-lang:masterfrom Aug 15, 2021
Merged
Support reading test-specific environment from *ENV.dhall file#2268Gabriella439 merged 4 commits intodhall-lang:masterfrom
Gabriella439 merged 4 commits intodhall-lang:masterfrom
Conversation
6 tasks
sjakobi
reviewed
Aug 12, 2021
Collaborator
sjakobi
left a comment
There was a problem hiding this comment.
I don't see much to complain about, but I'm not very familiar with the context, so I'd prefer if @Gabriel439 could review this too.
dhall/tests/Dhall/Test/Util.hs
Outdated
| setEnv :: (Text, Text) -> IO (Text, Maybe Text) | ||
| setEnv (k, v) = do | ||
| old <- Turtle.need k | ||
| _ <- putStrLn $ Text.unpack $ "Setting env: "<>k <> "="<>v |
Collaborator
There was a problem hiding this comment.
If needed, such logging should go to stderr.
Collaborator
There was a problem hiding this comment.
I would omit the logging here
Gabriella439
approved these changes
Aug 13, 2021
Collaborator
Gabriella439
left a comment
There was a problem hiding this comment.
Looks good! Just one comment
dhall/tests/Dhall/Test/Util.hs
Outdated
| setEnv :: (Text, Text) -> IO (Text, Maybe Text) | ||
| setEnv (k, v) = do | ||
| old <- Turtle.need k | ||
| _ <- putStrLn $ Text.unpack $ "Setting env: "<>k <> "="<>v |
Collaborator
There was a problem hiding this comment.
I would omit the logging here
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This will be a new requirement for the standard test suite as part of dhall-lang/dhall-lang#1192
I did this on my WIP branch (#2236), but it seems independent enough to review early.