Skip to content

Implement with without syntactic sugar#2055

Merged
mergify[bot] merged 3 commits intomasterfrom
gabriel/direct_with
Sep 28, 2020
Merged

Implement with without syntactic sugar#2055
mergify[bot] merged 3 commits intomasterfrom
gabriel/direct_with

Conversation

@Gabriella439
Copy link
Copy Markdown
Collaborator

… as standardized in dhall-lang/dhall-lang#1073

… by restoring the `desugarWith` utility, even if it's only used by
`dhall-nix`
… as caught by @sjakobi

Co-authored-by: Simon Jakobi <simon.jakobi@gmail.com>
@mergify mergify bot merged commit 29199f5 into master Sep 28, 2020
@mergify mergify bot deleted the gabriel/direct_with branch September 28, 2020 16:37
@JohannesRudolph
Copy link
Copy Markdown

I see you're making further changes to the with implementation. I suppose this change should not regress dhall format behavior around #2047 ?

Are there any plans on shipping a v1.35.1 that would include these fixes soon? I'm asking because we are heavy users of with and would like to upgrade from v1.31 and so far the changes around it have been holding us back.

@Gabriella439
Copy link
Copy Markdown
Collaborator Author

@JohannesRudolph: We release monthly, so there should be a new release coming out soon (~1 week)

#2048 added a regression test to ensure that the original problem won't recur, so you don't need to worry about any regressions due to the subsequent with-related changes

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants