Skip to content

Commit ad9d03e

Browse files
dgroupdgroup
committed
#48: Up code coverage
1 parent 8f8bb6e commit ad9d03e

10 files changed

Lines changed: 28 additions & 83 deletions

File tree

‎src/main/java/io/github/dgroup/enumerable4j/Linked.java‎

Lines changed: 2 additions & 11 deletions
Original file line numberDiff line numberDiff line change
@@ -23,7 +23,6 @@
2323
*/
2424
package io.github.dgroup.enumerable4j;
2525

26-
import java.util.List;
2726
import org.cactoos.list.ListEnvelope;
2827
import org.cactoos.list.ListOf;
2928

@@ -41,22 +40,14 @@ public class Linked<X> extends ListEnvelope<X> implements Enumerable<X> {
4140
*/
4241
@SafeVarargs
4342
public Linked(final X... src) {
44-
this(new ListOf<>(src));
43+
super(new ListOf<>(src));
4544
}
4645

4746
/**
4847
* Ctor.
4948
* @param src The source items.
5049
*/
5150
public Linked(final Iterable<X> src) {
52-
this(new ListOf<>(src));
53-
}
54-
55-
/**
56-
* Ctor.
57-
* @param src The source items.
58-
*/
59-
public Linked(final List<X> src) {
60-
super(src);
51+
super(new ListOf<>(src));
6152
}
6253
}

‎src/test/java/io/github/dgroup/enumerable4j/AllTest.java‎

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -43,7 +43,7 @@ final class AllTest {
4343
void all() {
4444
new Assertion<>(
4545
"All values in enumerable are positive",
46-
new FakeCollection<>(1, 2, 3).all(val -> val > 0),
46+
new Linked<>(1, 2, 3).all(val -> val > 0),
4747
new IsTrue()
4848
).affirm();
4949
}
@@ -52,7 +52,7 @@ void all() {
5252
void negative() {
5353
new Assertion<>(
5454
"All values in enumerable are negative",
55-
new FakeCollection<>(1, 2, 3).all(val -> val < 0),
55+
new Linked<>(1, 2, 3).all(val -> val < 0),
5656
new IsEqual<>(false)
5757
).affirm();
5858
}
@@ -61,7 +61,7 @@ void negative() {
6161
void nullPredicate() {
6262
new Assertion<>(
6363
"In case of null predicate we will get true",
64-
new FakeCollection<>(1, 2, 3).all(null),
64+
new Linked<>(1, 2, 3).all(null),
6565
new IsTrue()
6666
).affirm();
6767
}

‎src/test/java/io/github/dgroup/enumerable4j/AnyTest.java‎

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -42,7 +42,7 @@ final class AnyTest {
4242
void any() {
4343
new Assertion<>(
4444
"At least one element in enumerable is less than 0",
45-
new FakeCollection<>(-1, 0, 1, 2).any(val -> val < 0),
45+
new Linked<>(-1, 0, 1, 2).any(val -> val < 0),
4646
new IsTrue()
4747
).affirm();
4848
}
@@ -51,7 +51,7 @@ void any() {
5151
void negative() {
5252
new Assertion<>(
5353
"At least one value in enumerable is negative",
54-
new FakeCollection<>(1, 2, 3).any(val -> val < 0),
54+
new Linked<>(1, 2, 3).any(val -> val < 0),
5555
new IsEqual<>(false)
5656
).affirm();
5757
}
@@ -60,7 +60,7 @@ void negative() {
6060
void nullPredicate() {
6161
new Assertion<>(
6262
"In case of null predicate we will get true",
63-
new FakeCollection<>(1, 2, 3).any(null),
63+
new Linked<>(1, 2, 3).any(null),
6464
new IsTrue()
6565
).affirm();
6666
}

‎src/test/java/io/github/dgroup/enumerable4j/CountTest.java‎

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -41,7 +41,7 @@ final class CountTest {
4141
void truePredicate() {
4242
new Assertion<>(
4343
"One element in enumerable is less than 0",
44-
new FakeCollection<>(-1, 0, 1, 2).count(val -> val < 0),
44+
new Linked<>(-1, 0, 1, 2).count(val -> val < 0),
4545
new IsEqual<>(1L)
4646
).affirm();
4747
}
@@ -50,7 +50,7 @@ void truePredicate() {
5050
void falsePredicate() {
5151
new Assertion<>(
5252
"No element in enumerable is less than 0",
53-
new FakeCollection<>(7, 0, 1, 2).count(val -> val < 0),
53+
new Linked<>(7, 0, 1, 2).count(val -> val < 0),
5454
new IsEqual<>(0L)
5555
).affirm();
5656
}
@@ -59,7 +59,7 @@ void falsePredicate() {
5959
void nullPredicate() {
6060
new Assertion<>(
6161
"In case of null predicate it will work as size",
62-
new FakeCollection<>(1, 2, 3).count(null),
62+
new Linked<>(1, 2, 3).count(null),
6363
new IsEqual<>(3L)
6464
).affirm();
6565
}

‎src/test/java/io/github/dgroup/enumerable4j/FakeCollection.java‎

Lines changed: 0 additions & 46 deletions
This file was deleted.

‎src/test/java/io/github/dgroup/enumerable4j/FindTest.java‎

Lines changed: 7 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -30,7 +30,7 @@
3030
import org.llorllale.cactoos.matchers.Assertion;
3131

3232
/**
33-
* Test cases for {@link FakeCollection#find}.
33+
* Test cases for {@link Enumerable#find}.
3434
*
3535
* @since 0.1.0
3636
* @checkstyle MagicNumberCheck (500 lines)
@@ -42,7 +42,7 @@ final class FindTest {
4242
void find() {
4343
new Assertion<>(
4444
"First number bigger than 0",
45-
new FakeCollection<>(-1, 0, 1, 2, 3).find(val -> val > 0),
45+
new Linked<>(-1, 0, 1, 2, 3).find(val -> val > 0),
4646
new IsEqual<>(1)
4747
).affirm();
4848
}
@@ -51,7 +51,7 @@ void find() {
5151
void nullPredicate() {
5252
new Assertion<>(
5353
"In case of null predicate we will get the same enumerable",
54-
new FakeCollection<>(1, 2, 3).find(null),
54+
new Linked<>(1, 2, 3).find(null),
5555
new IsNull<>()
5656
).affirm();
5757
}
@@ -60,7 +60,7 @@ void nullPredicate() {
6060
void negative() {
6161
new Assertion<>(
6262
"There are no prime numbers",
63-
new FakeCollection<>(2, 4, 6, 8).find(val -> val % 2 != 0),
63+
new Linked<>(2, 4, 6, 8).find(val -> val % 2 != 0),
6464
new IsNull<>()
6565
).affirm();
6666
}
@@ -69,7 +69,7 @@ void negative() {
6969
void altFind() {
7070
new Assertion<>(
7171
"First number bigger than 0",
72-
new FakeCollection<>(-1, 0, 1, 2, 3).find(val -> val > 0, 100),
72+
new Linked<>(-1, 0, 1, 2, 3).find(val -> val > 0, 100),
7373
new IsEqual<>(1)
7474
).affirm();
7575
}
@@ -78,7 +78,7 @@ void altFind() {
7878
void altNullPredicate() {
7979
new Assertion<>(
8080
"In case of null predicate we will get the same enumerable",
81-
new FakeCollection<>(1, 2, 3).find(null, 100),
81+
new Linked<>(1, 2, 3).find(null, 100),
8282
new IsEqual<>(100)
8383
).affirm();
8484
}
@@ -87,7 +87,7 @@ void altNullPredicate() {
8787
void altNegative() {
8888
new Assertion<>(
8989
"There are no prime numbers",
90-
new FakeCollection<>(2, 4, 6, 8).find(val -> val % 2 != 0, 777),
90+
new Linked<>(2, 4, 6, 8).find(val -> val % 2 != 0, 777),
9191
new IsEqual<>(777)
9292
).affirm();
9393
}

‎src/test/java/io/github/dgroup/enumerable4j/MapTest.java‎

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -43,7 +43,7 @@ final class MapTest {
4343
void map() {
4444
new Assertion<>(
4545
"All numbers where multiplied on 10",
46-
new FakeCollection<>(2, 3, 4).map(val -> val * 10),
46+
new Linked<>(2, 3, 4).map(val -> val * 10),
4747
new HasValues<>(20, 30, 40)
4848
).affirm();
4949
}
@@ -52,7 +52,7 @@ void map() {
5252
void nullFunction() {
5353
new Assertion<>(
5454
"All numbers are the same",
55-
new FakeCollection<>(2, 3, 4).map(null),
55+
new Linked<>(2, 3, 4).map(null),
5656
new IsEmptyIterable<>()
5757
).affirm();
5858
}
@@ -61,7 +61,7 @@ void nullFunction() {
6161
void negative() {
6262
new Assertion<>(
6363
"All numbers converted to numbers squares",
64-
new FakeCollection<>(0, 1, 2, 3).map(val -> val * val),
64+
new Linked<>(0, 1, 2, 3).map(val -> val * val),
6565
new IsNot<>(
6666
new HasValues<>(5, 7, 9)
6767
)

‎src/test/java/io/github/dgroup/enumerable4j/NoneTest.java‎

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -42,7 +42,7 @@ final class NoneTest {
4242
void none() {
4343
new Assertion<>(
4444
"There are no values in enumerable greater than 100",
45-
new FakeCollection<>(-1, 2, 99).none(val -> val > 100),
45+
new Linked<>(-1, 2, 99).none(val -> val > 100),
4646
new IsTrue()
4747
).affirm();
4848
}
@@ -51,7 +51,7 @@ void none() {
5151
void negative() {
5252
new Assertion<>(
5353
"All values in enumerable are negative",
54-
new FakeCollection<>(1, 2, 3).none(val -> val < 0),
54+
new Linked<>(1, 2, 3).none(val -> val < 0),
5555
new IsEqual<>(true)
5656
).affirm();
5757
}
@@ -60,7 +60,7 @@ void negative() {
6060
void nullPredicate() {
6161
new Assertion<>(
6262
"In case of null predicate we will get true",
63-
new FakeCollection<>(1, 2, 3).none(null),
63+
new Linked<>(1, 2, 3).none(null),
6464
new IsTrue()
6565
).affirm();
6666
}

‎src/test/java/io/github/dgroup/enumerable4j/RejectTest.java‎

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -44,7 +44,7 @@ final class RejectTest {
4444
void reject() {
4545
new Assertion<>(
4646
"Negative values from enumerable found",
47-
new FakeCollection<>(1, 2, 3, -1).reject(val -> val > 0),
47+
new Linked<>(1, 2, 3, -1).reject(val -> val > 0),
4848
new AllOf<>(
4949
new HasSize(1),
5050
new HasValues<>(-1)
@@ -56,7 +56,7 @@ void reject() {
5656
void nullFunction() {
5757
new Assertion<>(
5858
"In case null-function the self enumerable is expected",
59-
new FakeCollection<>(3, 0, 2, -1).reject(null),
59+
new Linked<>(3, 0, 2, -1).reject(null),
6060
new HasValues<>(3, 0, 2, -1)
6161
).affirm();
6262
}

‎src/test/java/io/github/dgroup/enumerable4j/SelectTest.java‎

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -44,7 +44,7 @@ final class SelectTest {
4444
void select() {
4545
new Assertion<>(
4646
"Positive values from enumerable found",
47-
new FakeCollection<>(3, 0, 2, -1).select(val -> val > 0),
47+
new Linked<>(3, 0, 2, -1).select(val -> val > 0),
4848
new AllOf<>(
4949
new HasSize(2),
5050
new HasValues<>(3, 2)
@@ -56,7 +56,7 @@ void select() {
5656
void nullFunction() {
5757
new Assertion<>(
5858
"In case null-function the self enumerable is expected",
59-
new FakeCollection<>(3, 0, 2, -1).select(null),
59+
new Linked<>(3, 0, 2, -1).select(null),
6060
new HasValues<>(3, 0, 2, -1)
6161
).affirm();
6262
}

0 commit comments

Comments
 (0)