Skip to content

chore(test): fix test files compilation on 32-bit archs (#465)#470

Merged
matthewmcneely merged 1 commit intodgraph-io:mainfrom
jas4711:fix-32bit
Dec 10, 2025
Merged

chore(test): fix test files compilation on 32-bit archs (#465)#470
matthewmcneely merged 1 commit intodgraph-io:mainfrom
jas4711:fix-32bit

Conversation

@jas4711
Copy link
Contributor

@jas4711 jas4711 commented Oct 4, 2025 •
edited by matthewmcneely
Loading

Description

Use int64 as suggested in #465 for variables holding >2^31 values.

Checklist

  • Code compiles correctly and linting passes locally
  • For all code changes, an entry added to the CHANGELOG.md file describing and linking to
    this PR
  • Tests added for new functionality, or regression tests for bug fixes added as applicable

Instructions

  • The PR title should follow the Conventional Commits
    syntax, leading with fix:, feat:, chore:, ci:, etc.
  • The description should briefly explain what the PR is about. In the case of a bugfix, describe or
    link to the bug.
  • In the checklist section, check the boxes in that are applicable, using [x] syntax.
    • If not applicable, remove the entire line. Only leave the box unchecked if you intend to come
      back and check the box later.
  • Delete the Instructions line and everything below it, to indicate you have read and are
    following these instructions. 🙂

Thank you for your contribution to Ristretto!

@jas4711 jas4711 requested a review from a team October 4, 2025 11:55
@CLAassistant
Copy link

CLAassistant commented Oct 4, 2025 •
edited
Loading

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.
You have signed the CLA already but the status is still pending? Let us recheck it.

@matthewmcneely matthewmcneely force-pushed the fix-32bit branch 2 times, most recently from 1df4a39 to 3081d43 Compare October 5, 2025 21:12
@jas4711 @matthewmcneely
Fix compilation on 32-bit archs (dgraph-io#465)
d5fd4d1 
src/github.com/dgraph-io/ristretto/sketch_test.go:67:8: cannot use 12 << 30 (untyped int constant 12884901888) as int value in assignment (overflows)
src/github.com/dgraph-io/ristretto/store_test.go:209:23: cannot use 4340958203495 (untyped int constant) as int value in argument to z.KeyToHash (overflows)
@matthewmcneely matthewmcneely requested a review from a team as a code owner December 10, 2025 20:18
@matthewmcneely matthewmcneely changed the title Fix compilation on 32-bit archs (#465) chore(test): fix test files compilation on 32-bit archs (#465) Dec 10, 2025
@matthewmcneely matthewmcneely merged commit 4f24d62 into dgraph-io:main Dec 10, 2025
2 checks passed
@matthewmcneely matthewmcneely mentioned this pull request Jan 20, 2026
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@matthewmcneely matthewmcneely matthewmcneely approved these changes

Assignees

No one assigned

Labels

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@jas4711 @CLAassistant @matthewmcneely