Fix assertion in TestDropUpdates and trunk upgrade#452
Merged
mangalaman93 merged 1 commit intomainfrom Jun 16, 2025
Merged
Conversation
There was a problem hiding this comment.
Pull Request Overview
This PR fixes an assertion in TestDropUpdates and updates the project's trunk configuration to use newer versions of tools and runtimes.
- Fixes the assertion in cache_test.go by explicitly converting -1 to int64.
- Updates .trunk/trunk.yaml to use newer CLI, plugin, runtime, and linter versions.
- Enhances .trunk/configs/.golangci.json with additional exclusion rules and bumps the configuration version.
Reviewed Changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| cache_test.go | Fixes assertion by using explicit int64 conversion. |
| .trunk/trunk.yaml | Updates tool versions including CLI, plugins, and linters. |
| .trunk/configs/.golangci.json | Adds exclusion rules and updates the configuration version. |
|
Running Code Quality on PRs by uploading data to Trunk will soon be removed. You can still run checks on your PRs using trunk-action - see the migration guide for more information. |
ghost
approved these changes
Jun 16, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #451