Skip to content

fix: race in close#384

Merged
mangalaman93 merged 3 commits intodgraph-io:mainfrom
wundergraph:fix-race-in-close
Jul 23, 2024
Merged

fix: race in close#384
mangalaman93 merged 3 commits intodgraph-io:mainfrom
wundergraph:fix-race-in-close

Conversation

@StarpTech
Copy link
Contributor

Related: #294

Fixes: #377

@CLAassistant
Copy link

CLAassistant commented Jul 15, 2024

CLA assistant check
All committers have signed the CLA.

@StarpTech StarpTech marked this pull request as ready for review July 15, 2024 08:11
@StarpTech StarpTech requested a review from a team July 15, 2024 08:11
@mangalaman93
Copy link
Contributor

Hi @StarpTech, Thanks for the PR. Apologies for the delay. Would it be possible for you to explain/use the sync/atomic package instead?

@StarpTech
Copy link
Contributor Author

@mangalaman93 no opinion on it. I copied the code from the previous contribution. I can also use the std library.

@mangalaman93
Copy link
Contributor

Yes, please. Std Library is perfect.

@StarpTech
Copy link
Contributor Author

StarpTech commented Jul 19, 2024

I already used it but I did not tidy. Please recheck.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Development

Successfully merging this pull request may close these issues.

Missing commits/PRs on main

3 participants