fix(OnEvict): Set missing Expiration field on evicted items#345
Merged
mangalaman93 merged 1 commit intodgraph-io:mainfrom Aug 31, 2023
Merged
fix(OnEvict): Set missing Expiration field on evicted items#345mangalaman93 merged 1 commit intodgraph-io:mainfrom
fix(OnEvict): Set missing Expiration field on evicted items#345mangalaman93 merged 1 commit intodgraph-io:mainfrom
Conversation
|
|
|
|
mangalaman93
approved these changes
Aug 31, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
On our use case we need to rely on expiration timestamps but we realized that they return zero timestamps. Our assumption is that this is due to a bug and not by design.
Problem
When
OnEvictcallback is executedItemdoes not haveExpirationfield set. Considering it is a public field this needs to be set and available.Solution
Initialize
Expirationfield before calling theonEvictcallback