fix: support compilation to wasip1#344
Merged
mangalaman93 merged 1 commit intodgraph-io:mainfrom Aug 29, 2023
Merged
Conversation
Signed-off-by: Achille Roussel <achille.roussel@gmail.com>
|
|
mangalaman93
approved these changes
Aug 29, 2023
Contributor
|
Thank you for the PR |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
I'm interested in getting ristretto to build to the new
wasip1target, but it fails due to ristretto's assumption that the program is being compiled to a unix system where files can be mapped to memory. At this time, thex/sys/unixpackage does not considerwasip1to be a unix platform, and memory mapping isn't supported either when compiling to WebAssembly.Solution
The proposed solution in this PR is to provide stubs implementations of the memory mapping functions which return
ENOSYSto indicate that the functionalities are not available when compiled toGOOS=wasip1.If I'm reading the code correctly, this means that persisting data structures to a storage medium will not be supported, but the rest of ristretto should work as expected.
I believe this to be a useful trade-off since many dependents of ristretto only use the in-memory data structures (e.g. https://github.com/DataDog/datadog-agent/blob/main/pkg/obfuscate/cache.go, which is what I'm interested in getting to compile).
A more advanced solution could be to rework the
z.Bufferinternals so the data structure can work on platforms where mapping files to memory isn't supported; however, this represents a bigger undertaking, I would like to first unblock dependencies by allowing the program to compile.Please let me know if you have any concerns or feedback on the change!