Skip to content

docs(Cache): document Wait, clarify Get#333

Merged
mangalaman93 merged 1 commit intodgraph-io:mainfrom
evanj:evan.jones/ristretto-docs
May 16, 2023
Merged

docs(Cache): document Wait, clarify Get#333
mangalaman93 merged 1 commit intodgraph-io:mainfrom
evanj:evan.jones/ristretto-docs

Conversation

@evanj
Copy link
Contributor

@evanj evanj commented Mar 23, 2023

  • Document the Wait() function.
  • Clarify that Get() will never return expired items.
  • Clarify in what circumstances Get() can return (nil, true).

@CLAassistant
Copy link

CLAassistant commented Mar 23, 2023 •
edited
Loading

CLA assistant check
All committers have signed the CLA.

@evanj
Copy link
Contributor Author

evanj commented Mar 26, 2023

Hmmm TestDropUpdates failed but is flaky. On my local machine I am able to get it to fail on the main branch. I'll see if I can make a separate PR to address that. For now I'm going to change this commit to trigger the tests again.

@evanj
Cache: document Wait, clarify Get
bc0dd5f 
* Document the Wait() function.
* Clarify that Get() will never return expired items.
* Clarify in what circumstances Get() can return (nil, true).
@skrdgraph
Copy link

skrdgraph commented Mar 27, 2023

Hmmm TestDropUpdates failed but is flaky. On my local machine I am able to get it to fail on the main branch. I'll see if I can make a separate PR to address that. For now I'm going to change this commit to trigger the tests again.

related PR #334

@mangalaman93 mangalaman93 merged commit 9577449 into dgraph-io:main May 16, 2023
@veramine
Copy link

veramine commented May 20, 2023

Thank you for this documentation update. I recently got into an argument with ChatGPT over this exact situation 🤣🤣🤣
1
2
3

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@mangalaman93 mangalaman93 mangalaman93 approved these changes

@akon-dey akon-dey Awaiting requested review from akon-dey

@joshua-goldstein joshua-goldstein Awaiting requested review from joshua-goldstein

+1 more reviewer

@skrdgraph skrdgraph skrdgraph approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@evanj @CLAassistant @skrdgraph @veramine @mangalaman93