Merged
Conversation
z/buffer.go
Outdated
| if b.maxSz-int(b.offset) < n { | ||
| panic(fmt.Sprintf("Buffer max size exceeded: %d."+ | ||
| " Offset: %d. Grow: %d", b.maxSz, b.offset, n)) | ||
| if b.maxSz != 0 && int(b.offset)+n > b.maxSz { |
Contributor
There was a problem hiding this comment.
When can b.maxSz be 0? It should always have a valid value.
Contributor
Author
There was a problem hiding this comment.
I've kept the zero value as an "unbounded" buffer. The earlier API set maxSz = math.MaxInt32 (roughly 2.1GB) by default. The caller is expected to set this using the WithMaxSize API now. Should I change it back?
manishrjain
approved these changes
Apr 22, 2021
Contributor
manishrjain
left a comment
There was a problem hiding this comment.
Reviewed 4 of 4 files at r2.
Reviewable status: all files reviewed, 2 unresolved discussions (waiting on @ajeetdsouza and @jarifibrahim)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
z.Treeshould use az.Bufferbacking.z.Buffershould use az.MmapFilebacking.z.Buffer, so it doesn't delete the file after closing.z.Tree, so that we can use it for persistent storage.This change is