Fix(buffer): Expose padding by z.Buffer's APIs and fix test#222
Merged
ahsanbarkati merged 2 commits intomasterfrom Nov 12, 2020
Merged
Fix(buffer): Expose padding by z.Buffer's APIs and fix test#222ahsanbarkati merged 2 commits intomasterfrom
ahsanbarkati merged 2 commits intomasterfrom
Conversation
jarifibrahim
approved these changes
Nov 12, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We need to include the padding in the offsets returned by the APIs because we use zero offset as a check for nil nodes.
It also removes the API
IncrementOffset()because it was being used only in skiplist and we don't need it anymore.This change is