Use mremap on Linux instead of munmap+mmap#221
Merged
ajeetdsouza merged 3 commits intomasterfrom Nov 10, 2020
Merged
Conversation
jarifibrahim
approved these changes
Nov 10, 2020
Contributor
jarifibrahim
left a comment
There was a problem hiding this comment.
Clean it up and it's good to merge
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Linux exposes an
mremapfunction that is not available on other OSes, that allows us to remap an address space, providing a more efficient way to increase the size of an mmap file. This PR allows Linux systems to use themremapcall, while other OSes continue to usemunmapfollowed bymmap.sysdoes not provide anmremapfunction, so this had to handwritten using a system call. Unfortunately, the functions provided bysysforMmap/Munmapmaintain a list of active mappings, and do not allow us toMunmapanything that is not present in the list. Since our handwrittenmremapcall cannot update that internal list, we must reimplement themunmapsystem call as well.This change is