Buffer: Use 256GB mmap size instead of MaxInt64#198
Merged
Conversation
martinmr
suggested changes
Sep 28, 2020
Contributor
martinmr
left a comment
There was a problem hiding this comment.
Reviewed 1 of 1 files at r1.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @anurags92, @jarifibrahim, @karlmcguire, and @manishrjain)
z/buffer.go, line 73 at r1 (raw file):
// Newbuffer is a helper utility, which creates a virtually unlimited Buffer in UseCalloc mode. func NewBuffer(sz int) *Buffer { buf, err := NewBufferWith(sz, math.MaxInt32, UseCalloc)
so this is now 2GB. not virtually unlimited anymore. Is that ok?
jarifibrahim
commented
Sep 28, 2020
Contributor
Author
jarifibrahim
left a comment
There was a problem hiding this comment.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @anurags92, @karlmcguire, @manishrjain, and @martinmr)
z/buffer.go, line 73 at r1 (raw file):
Previously, martinmr (Martin Martinez Rivera) wrote…
so this is now 2GB. not virtually unlimited anymore. Is that ok?
I can make it 100*math.maxInt32 or something. math.MaxInt64 crashes on my computer.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
MaxInt64 is 9.2 Exabyte and the test fails with
cannot allocate memoryon my computer.This PR also fixes the build (it is failing on master).
This change is