Skip to content

fix(vlog): Log error on missing vlog#1628

Merged
aman-bansal merged 1 commit intorelease/v2.2007from
ibrahim/r2.2007-missing-vlog
Dec 28, 2020
Merged

fix(vlog): Log error on missing vlog#1628
aman-bansal merged 1 commit intorelease/v2.2007from
ibrahim/r2.2007-missing-vlog

Conversation

@jarifibrahim
Copy link
Contributor

@jarifibrahim jarifibrahim commented Dec 24, 2020 •
edited
Loading

We recently saw a crash on vlog.write function that could only happen if the vlog file with maxFid doesn't exist in the filesMap (which is highly unlikely). This PR adds appropriate errors so that we can debug this issue futher.

I1224 06:04:48.314143 3930260 backup_processor.go:236] Backup completed OK.
panic: runtime error: invalid memory address or nil pointer dereference
[signal SIGSEGV: segmentation violation code=0x1 addr=0x30 pc=0x123e26c]

goroutine 21121096 [running]:
github.com/dgraph-io/badger/v2.(*valueLog).write(0xc0000815d0, 0xc049c46410, 0x1, 0xa, 0x0, 0x0)
        /home/dg/go/pkg/mod/github.com/dgraph-io/badger/v2@v2.2007.3-0.20200927102853-5e3d4b9926a7/value.go:1497 +0x2cc
github.com/dgraph-io/badger/v2.(*DB).writeRequests(0xc000081400, 0xc049c46410, 0x1, 0xa, 0x0, 0x10000c00865dc20)
        /home/dg/go/pkg/mod/github.com/dgraph-io/badger/v2@v2.2007.3-0.20200927102853-5e3d4b9926a7/db.go:776 +0xd1
github.com/dgraph-io/badger/v2.(*DB).doWrites.func1(0xc049c46410, 0x1, 0xa)
        /home/dg/go/pkg/mod/github.com/dgraph-io/badger/v2@v2.2007.3-0.20200927102853-5e3d4b9926a7/db.go:850 +0x5a
created by github.com/dgraph-io/badger/v2.(*DB).doWrites
        /home/dg/go/pkg/mod/github.com/dgraph-io/badger/v2@v2.2007.3-0.20200927102853-5e3d4b9926a7/db.go:903 +0x32b

Fixes DGRAPH-2884

This change is Reviewable

@aman-bansal aman-bansal merged commit 3f846b3 into release/v2.2007 Dec 28, 2020
@NamanJain8 NamanJain8 deleted the ibrahim/r2.2007-missing-vlog branch July 21, 2021 06:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@manishrjain manishrjain Awaiting requested review from manishrjain

1 more reviewer

@aman-bansal aman-bansal aman-bansal approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@jarifibrahim @aman-bansal