UX: add FindingDetailModal — finding detail with evidence, sources, confidence (#290)#91
Merged
dgarson merged 2 commits intofeat/horizon-post-mergefrom Feb 23, 2026
Conversation
…penclaw#313) - New AgentTopologyMap.tsx: pure SVG + React state, no external graph libs - Static concentric layout: principals (r=210), crons (r=115), workers (r=65 from spawner) - Node types: Principal (violet circle), Worker (blue circle), Cron (amber diamond) - Interactive: click-to-inspect detail panel (280px), hover scale effect - Toolbar: Live/Paused toggle, Reset View, session count badge, legend - Mock data: 6 principals, 4 workers (from Luis), 2 crons - Also fix pre-existing TS build errors to get 0-error build: - AgentOutputDiffViewer: remove invalid lucide icons + syntax error - APICredentialHealthDashboard: fix Badge/Alert variants, remove indicatorClassName - AgentSkillHeatmap, AgentSoulEditor, DiscoveryRunReplayControls, FindingTrendChart, ModelComparisonMatrix: pre-existing fixes - Add missing ui/alert badge card progress components
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
View openclaw#290: Full-page modal-style detail view for a single discovery finding.
Sections Built
Mock Data
Critical finding: "Exposed API key in agent SOUL.md" with SecurityScanner + SecretSniffer attribution, 97% confidence, 4 sources, immediate remediation steps.
Accessibility (Reed's specialty)
role="dialog"+aria-modalsemanticsaria-liveregions for dynamic state (resolved, urgency alerts)aria-expandedon all collapsible panelsfocus-visible:ring-violet-500on all interactive elementsrole="progressbar"witharia-valuenow/min/maxon confidence gaugerole="alert"on urgency banners (critical/high)aria-hidden="true"Build
✓ 0 TypeScript errors
✓ Vite build passes (1865 modules)
Line Count
938 insertions