Skip to content

fix(web-next): harden gateway handshake/call flow, make e2e env-configurable, and refresh audit#179

Merged
dgarson merged 1 commit intodgarson/forkfrom
codex/identify-and-resolve-branch-discrepancies
Feb 24, 2026
Merged

fix(web-next): harden gateway handshake/call flow, make e2e env-configurable, and refresh audit#179
dgarson merged 1 commit intodgarson/forkfrom
codex/identify-and-resolve-branch-discrepancies

Conversation

@dgarson
Copy link
Owner

@dgarson dgarson commented Feb 24, 2026

Motivation

  • Remove fragile/race-prone gateway behavior and hardcoded endpoints in the Web UI so environments and first-call flows behave predictably.
  • Reduce CI/local e2e brittleness caused by a hardcoded base URL and repository-tracked screenshot artifacts.
  • Reflect remediation progress in the branch audit by documenting remaining issues and what was addressed.

Description

  • Make the gateway endpoint configurable by reading import.meta.env.VITE_GATEWAY_URL with a ws://localhost:18789 fallback, replacing the previous hardcoded value in useGateway.
  • Add a connection promise/handshake mechanism to useGateway so call() awaits a successful hello handshake instead of rejecting immediately, and track/resolve/reject that promise across open/error/close/timeout flows.
  • Change hello timeout behavior to set an explicit error state, reject waiting callers, and close the socket instead of treating the connection as connected on timeout.
  • Update Playwright smoke tests to read PLAYWRIGHT_BASE_URL (fallback http://127.0.0.1:5173) and to write screenshots to ephemeral artifact paths with testInfo.outputPath(...) rather than writing tracked files.
  • Add apps/web-next/screenshots/ to .gitignore and remove previously committed screenshot binaries to avoid repository churn.
  • Replace docs/branch-upstream-audit.md with a focused document that lists remaining unresolved issues and records the specific fixes applied in this pass.

Testing

  • Ran repository validation with git diff --check, which reported no whitespace/check issues.
  • Attempted a local build with pnpm -C apps/web-next build; the build failed in this environment due to missing node_modules and missing React/type dependencies, not because of the code changes (build failure is an environment dependency issue).
  • No CI Playwright run was performed in this environment; e2e test files were updated to be CI/config-friendly and to emit artifacts to Playwright output paths.

Codex Task

@dgarson dgarson changed the base branch from dgarson/fork to feat/horizon-ui-complete February 24, 2026 15:14
@dgarson dgarson changed the base branch from feat/horizon-ui-complete to dgarson/fork February 24, 2026 15:14
@dgarson dgarson merged commit 7ff6e7a into dgarson/fork Feb 24, 2026
1 of 4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant