Skip to content

claude: review pr fixes ma4d#106

Merged
dgarson merged 1 commit intotim/integration-test-scaffoldfrom
claude/review-pr-fixes-Ma4dL
Feb 23, 2026
Merged

claude: review pr fixes ma4d#106
dgarson merged 1 commit intotim/integration-test-scaffoldfrom
claude/review-pr-fixes-Ma4dL

Conversation

@dgarson
Copy link
Owner

@dgarson dgarson commented Feb 23, 2026

  • cmd_send: generate JSON via python3 json.dump instead of shell interpolation, fixing injection when subject/body/from contain quotes or backslashes
  • cmd_send: remove broken fallback (printf '"%s"') that produced invalid JSON when python3 was unavailable; add explicit python3 check at startup since the entire script depends on it
  • cmd_read: consolidate 5-6 python3 invocations per message into a single call, passing file path as argv instead of interpolating into Python code
  • cmd_drain: use a single file list for both display and archive phases, fixing a race where messages arriving between the two find calls were silently archived without being displayed
  • Create missing merlin/ and joey/ mailbox directories so the existing inbox symlinks (root inbox -> _shared/mailboxes/merlin, joey/inbox -> ../_shared/mailboxes/joey) actually resolve instead of being dangling
  • Re-add "Inbox (Heartbeat Step 0)" section to root AGENTS.md that was accidentally dropped by commit ccaa90e
  • Remove phantom workq_inbox_read/workq_inbox_ack references from joey/AGENTS.md (these tools have no implementation in any TS source)

https://claude.ai/code/session_01VMPrGXjrkcyiVd9wnq9fh1

Summary

Describe the problem and fix in 2–5 bullets:

  • Problem:
  • Why it matters:
  • What changed:
  • What did NOT change (scope boundary):

Change Type (select all)

  • Bug fix
  • Feature
  • Refactor
  • Docs
  • Security hardening
  • Chore/infra

Scope (select all touched areas)

  • Gateway / orchestration
  • Skills / tool execution
  • Auth / tokens
  • Memory / storage
  • Integrations
  • API / contracts
  • UI / DX
  • CI/CD / infra

Linked Issue/PR

  • Closes #
  • Related #

User-visible / Behavior Changes

List user-visible changes (including defaults/config).
If none, write None.

Security Impact (required)

  • New permissions/capabilities? (Yes/No)
  • Secrets/tokens handling changed? (Yes/No)
  • New/changed network calls? (Yes/No)
  • Command/tool execution surface changed? (Yes/No)
  • Data access scope changed? (Yes/No)
  • If any Yes, explain risk + mitigation:

Repro + Verification

Environment

  • OS:
  • Runtime/container:
  • Model/provider:
  • Integration/channel (if any):
  • Relevant config (redacted):

Steps

Expected

Actual

Evidence

Attach at least one:

  • Failing test/log before + passing after
  • Trace/log snippets
  • Screenshot/recording
  • Perf numbers (if relevant)

Human Verification (required)

What you personally verified (not just CI), and how:

  • Verified scenarios:
  • Edge cases checked:
  • What you did not verify:

Compatibility / Migration

  • Backward compatible? (Yes/No)
  • Config/env changes? (Yes/No)
  • Migration needed? (Yes/No)
  • If yes, exact upgrade steps:

Failure Recovery (if this breaks)

  • How to disable/revert this change quickly:
  • Files/config to restore:
  • Known bad symptoms reviewers should watch for:

Risks and Mitigations

List only real risks for this PR. Add/remove entries as needed. If none, write None.

  • Risk:
    • Mitigation:

…nks, and missing docs

- cmd_send: generate JSON via python3 json.dump instead of shell interpolation,
  fixing injection when subject/body/from contain quotes or backslashes
- cmd_send: remove broken fallback (printf '"%s"') that produced invalid JSON
  when python3 was unavailable; add explicit python3 check at startup since
  the entire script depends on it
- cmd_read: consolidate 5-6 python3 invocations per message into a single call,
  passing file path as argv instead of interpolating into Python code
- cmd_drain: use a single file list for both display and archive phases, fixing
  a race where messages arriving between the two find calls were silently
  archived without being displayed
- Create missing merlin/ and joey/ mailbox directories so the existing inbox
  symlinks (root inbox -> _shared/mailboxes/merlin, joey/inbox ->
  ../_shared/mailboxes/joey) actually resolve instead of being dangling
- Re-add "Inbox (Heartbeat Step 0)" section to root AGENTS.md that was
  accidentally dropped by commit ccaa90e
- Remove phantom workq_inbox_read/workq_inbox_ack references from
  joey/AGENTS.md (these tools have no implementation in any TS source)

https://claude.ai/code/session_01VMPrGXjrkcyiVd9wnq9fh1
@dgarson dgarson merged commit 420ddb9 into tim/integration-test-scaffold Feb 23, 2026
2 of 9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants