-
-
Notifications
You must be signed in to change notification settings - Fork 147
Description
Hi. Thanks for the library (and for the others OFC :-]).
I'm not sure what is the exact reason why there is the is_file check in
https://github.com/dg/dibi/blob/master/src/Dibi/Event.php#L66
I believe it's something clever but I'm not sure what is the condition trying to prevent, evaled source? Or something else could be there?
Perhaps it's not intended to use the logger/profiler in production but we do it to collect some metrics (and not only metrics).
When it's enabled (or a listener is registered) then each SQL query performs several system stat calls which slows our server.
Looks like it does not hit stat cache (stat is actually cached just for the last stat check).
So... what about removing the is_file entirely or replacing it with something else? ;-)