Guard type generic macro from C++ compilation#162
Merged
Conversation
Co-authored-by: awvwgk <28669218+awvwgk@users.noreply.github.com>
Co-authored-by: awvwgk <28669218+awvwgk@users.noreply.github.com>
Co-authored-by: awvwgk <28669218+awvwgk@users.noreply.github.com>
Copilot
AI
changed the title
[WIP] Fix type generic macro exposure for C++
Guard type generic macro from C++ compilation
Feb 6, 2026
Co-authored-by: awvwgk <28669218+awvwgk@users.noreply.github.com>
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #162 +/- ##
=======================================
Coverage 66.34% 66.34%
=======================================
Files 33 33
Lines 4627 4627
Branches 1608 1608
=======================================
Hits 3070 3070
Misses 637 637
Partials 920 920 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The
dftd3_deletetype generic macro uses C11's_Generic, which is incompatible with C++. Including the header in C++ code fails compilation.Changes
dftd3_deletemacro with#ifndef __cplusplusguard ininclude/s-dftd3.hUsage
C code continues using the type generic macro:
C++ code calls specific delete functions:
Original prompt
💡 You can make Copilot smarter by setting up custom instructions, customizing its development environment and configuring Model Context Protocol (MCP) servers. Learn more Copilot coding agent tips in the docs.