Merged
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #133 +/- ##
=======================================
Coverage 67.07% 67.07%
=======================================
Files 34 34
Lines 4687 4687
Branches 1647 1647
=======================================
Hits 3144 3144
Misses 632 632
Partials 911 911 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
awvwgk
approved these changes
Mar 4, 2025
Inside of dftd3, there is no check that mol%lattice is not allocated. Therefore, compiler can do some extra optimization which may lead to strange behaviour.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Inside of dftd3, there is no check that mol%lattice is not allocated. Therefore, compiler can do some extra optimization which may lead to strange behaviour.