Add FHI-aims to users of s-dftd3 library list#131
Merged
awvwgk merged 2 commits intodftd3:mainfrom Dec 20, 2024
Merged
Conversation
Signed-off by: James Green <green@ms1p.org>
awvwgk
approved these changes
Dec 19, 2024
Member
awvwgk
left a comment
There was a problem hiding this comment.
Thanks, great to see D3 in FHI-aims.
Some minor suggestions for the reference, otherwise looks good to me.
| date = {2009}, | ||
| journal = {Computer Physics Communications}, | ||
| title = {Ab initio molecular simulations with numeric atom-centered orbitals}, | ||
| doi = {https://doi.org/10.1016/j.cpc.2009.06.022}, |
Member
There was a problem hiding this comment.
Suggested change
| doi = {https://doi.org/10.1016/j.cpc.2009.06.022}, | |
| doi = {10.1016/j.cpc.2009.06.022}, |
| doi = {https://doi.org/10.1016/j.cpc.2009.06.022}, | ||
| number = {11}, | ||
| pages = {2175-2196}, | ||
| url = {https://www.sciencedirect.com/science/article/pii/S0010465509002033}, |
Member
There was a problem hiding this comment.
Suggested change
| url = {https://www.sciencedirect.com/science/article/pii/S0010465509002033}, | |
| url = {https://doi.org/10.1016/j.cpc.2009.06.022}, |
Signed-off by: James Green <green@ms1p.org>
Contributor
Author
|
Sure thing, I just updated the reference! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I recently implemented the simple-dftd3 library into FHI-aims (https://fhi-aims.org/), as of version 240920. Therefore I updated the "Users of this library" list in the docs to reflect this.