Skip to content

Fix scroll threshold for elements outside screen viewport#653

Merged
jalal246 merged 18 commits intomainfrom
dev/wip_5_28
May 31, 2023
Merged

Fix scroll threshold for elements outside screen viewport#653
jalal246 merged 18 commits intomainfrom
dev/wip_5_28

Conversation

@jalal246
Copy link
Member

@jalal246 jalal246 commented May 28, 2023

This PR addresses an issue with scroll thresholds for elements that are located outside the screen viewport. The scroll thresholds were not correctly calculated, leading to inaccurate auto-scrolling triggers for these elements.

The changes in this PR include:

  • Refactoring the scroll threshold calculation logic to ensure accurate detection of elements outside the viewport.
  • Updating the scroll threshold values to align with the element's position relative to the viewport.
  • Adding appropriate comments and documentation to clarify the purpose and functionality of the scroll threshold calculations.
  • Conducting e2e testing to validate the accuracy of the updated scroll thresholds.

@github-actions github-actions bot added the Core label May 28, 2023
@jalal246 jalal246 changed the title Dev/wip 5 28 Fix scroll thresholds for elements outside screen viewport May 31, 2023
@jalal246 jalal246 changed the title Fix scroll thresholds for elements outside screen viewport Fix scroll threshold for elements outside screen viewport May 31, 2023
@jalal246 jalal246 merged commit 39d2142 into main May 31, 2023
@jalal246 jalal246 deleted the dev/wip_5_28 branch May 31, 2023 14:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant