fix(agent): deduplicate parallel fetchSubnetKeys requests#1278
Merged
nikosxenakis merged 3 commits intodfinity:mainfrom Mar 10, 2026
Merged
fix(agent): deduplicate parallel fetchSubnetKeys requests#1278nikosxenakis merged 3 commits intodfinity:mainfrom
nikosxenakis merged 3 commits intodfinity:mainfrom
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR reduces redundant /read_state traffic by deduplicating concurrent HttpAgent.fetchSubnetKeys calls for the same canister, so parallel queries can share a single subnet-keys fetch.
Changes:
- Add an in-flight promise map to deduplicate parallel
fetchSubnetKeyscalls per canister. - Refactor
fetchSubnetKeysinto a public wrapper plus a private#doFetchSubnetKeysimplementation. - Add an e2e test validating only one
read_stateoccurs under parallel calls, and document the fix in the changelog.
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| packages/core/src/agent/agent/http/index.ts | Adds in-flight deduplication for subnet key fetching and extracts the core fetch logic. |
| e2e/node/basic/fetchSubnetKeys.test.ts | Adds a regression test ensuring parallel calls only produce one read_state request. |
| CHANGELOG.md | Notes the behavioral fix under Unreleased. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
4 tasks
nikosxenakis
requested changes
Mar 10, 2026
Contributor
nikosxenakis
left a comment
There was a problem hiding this comment.
Minor comment, the changes look good to me. Please rebase to latest main before approving.
When multiple query calls are issued in parallel for the same canister, each call triggers its own read_state round-trip to fetch subnet keys before the first response can populate the cache. This PR introduces an inflight deduplication map (#subnetKeysFetching) so that concurrent fetchSubnetKeys calls for the same canister share a single read_state round-trip instead of each issuing their own. Fixes dfinity#1179 Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
fetchSubnetKeys now returns the cached SubnetNodeKeys immediately when a valid entry exists within the TTL, avoiding a redundant read_state round-trip on sequential calls. Also adds an e2e test to verify that two sequential fetchSubnetKeys calls within the cache TTL produce only one read_state request. Addresses Copilot review feedback.
fe983ea to
5213a3c
Compare
Contributor
|
@yasumorishima Please ensure |
5213a3c to
6c175f7
Compare
Contributor
Author
|
Thanks for the review @nikosxenakis!
|
nikosxenakis
approved these changes
Mar 10, 2026
Contributor
nikosxenakis
left a comment
There was a problem hiding this comment.
@yasumorishima Thank you for the contribution! All changes look good, merging now.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
When multiple query calls are issued in parallel for the same canister, each call triggers its own
read_stateround-trip to fetch subnet keys before the first response can populate the cache.This PR introduces an inflight deduplication map (
#subnetKeysFetching) so that concurrentfetchSubnetKeyscalls for the same canister share a singleread_stateround-trip instead of each issuing their own.Fixes #1179
Changes
packages/core/src/agent/agent/http/index.ts: add#subnetKeysFetchingmap and splitfetchSubnetKeysinto public wrapper +#doFetchSubnetKeyse2e/node/basic/fetchSubnetKeys.test.ts: add parallel deduplication testCHANGELOG.md: add entry