feat(crypto): CRP-2709 improve vetKD API naming#4354
Merged
Conversation
schneiderstefan
approved these changes
Mar 13, 2025
eichhorl
reviewed
Mar 13, 2025
randombit
approved these changes
Mar 13, 2025
eichhorl
approved these changes
Mar 13, 2025
dsarlis
approved these changes
Mar 13, 2025
dsarlis
left a comment
Contributor
There was a problem hiding this comment.
Execution side looks good, see my comments for technically breaking changes but I think ones that we can live with.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Performs the following renamings in the vetKD API in accordance with the latest changes in the spec PR:
derivation_id-->inputderivation_idoften caused confusion andinputis a more standard name in the context of key derivation schemes.derivation_domain(previouslyderivation_path) -->contextvetkd_derive_encrypted_key-->vetkd_derive_keyvetkd_derive_encrypted_keyis somewhat long. In any case, in the returned struct the (single) field is still calledencrypted_key, so it is still explicit that the returned key is encrypted.encryption_public_key-->transport_public_keyvetkd_derive_encrypted_keyand the nameencryption_public_keyshould have made it clear that it is this very public key under which the encrypted key is encrypted. Now that we are removing the partencrypted_from the API name, this reason is obsolete and we are free to call ittransport_public_key.