Skip to content

feat: [EXC-1768] Add system API to get costs of management canister calls. #3584

Merged
michael-weigelt merged 90 commits into
masterfrom
mwe/costs
Feb 24, 2025
Merged

feat: [EXC-1768] Add system API to get costs of management canister calls. #3584
michael-weigelt merged 90 commits into
masterfrom
mwe/costs

Conversation

@michael-weigelt

@michael-weigelt michael-weigelt commented Jan 23, 2025 •
edited
Loading

Copy link
Copy Markdown
Contributor

This PR introduces system API endpoints that allow the caller to predict the cost of certain calls:

  • The cost of creating a canister
  • The cost of making an http outcall
  • The cost of an inter-canister call, i.e., the amount of cycles above the freezing threshold a canister must have in order to successfully perfom a call
  • The cost of signing with Ecdsa, Schnorr and deriving a VetKd key.

Design Doc

Spec PR

@github-actions github-actions Bot added the feat label Jan 23, 2025
michael-weigelt
michael-weigelt commented Jan 29, 2025
View reviewed changes
Comment thread rs/system_api/src/lib.rs Outdated
eichhorl
eichhorl reviewed Jan 29, 2025
View reviewed changes
Comment thread rs/interfaces/src/execution_environment.rs Outdated
Comment thread rs/interfaces/src/execution_environment.rs Outdated
Comment thread rs/interfaces/src/execution_environment.rs Outdated
Comment thread rs/interfaces/src/execution_environment.rs Outdated
eichhorl
eichhorl approved these changes Feb 4, 2025
View reviewed changes
Comment thread rs/types/management_canister_types/src/lib.rs Outdated
Comment thread rs/types/types/src/consensus/idkg/common.rs Outdated
@michael-weigelt michael-weigelt marked this pull request as ready for review February 12, 2025 15:12
@michael-weigelt michael-weigelt added the CI_ALL_BAZEL_TARGETS Runs all bazel targets label Feb 12, 2025
dragoljub-djuric
dragoljub-djuric reviewed Feb 13, 2025
View reviewed changes
Comment thread rs/config/src/subnet_config.rs
Comment thread rs/cycles_account_manager/src/lib.rs Outdated
Comment thread rs/interfaces/src/execution_environment.rs Outdated
Comment thread rs/system_api/src/lib.rs Outdated
Comment thread rs/system_api/src/lib.rs Outdated
Comment thread rs/system_api/src/sandbox_safe_system_state.rs Outdated
Comment thread rs/system_api/src/sandbox_safe_system_state.rs Outdated
Comment thread rs/system_api/tests/system_api.rs Outdated
mraszyk
mraszyk reviewed Feb 24, 2025
View reviewed changes
Comment thread rs/execution_environment/benches/lib/src/wat.rs Outdated
mraszyk
mraszyk reviewed Feb 24, 2025
View reviewed changes
Comment thread rs/types/management_canister_types/src/lib.rs
mraszyk
mraszyk reviewed Feb 24, 2025
View reviewed changes
Comment thread rs/interfaces/src/execution_environment.rs Outdated
mraszyk
mraszyk reviewed Feb 24, 2025
View reviewed changes
Comment thread rs/interfaces/src/execution_environment.rs Outdated
mraszyk
mraszyk reviewed Feb 24, 2025
View reviewed changes
Comment thread rs/interfaces/src/execution_environment.rs Outdated
mraszyk
mraszyk reviewed Feb 24, 2025
View reviewed changes
Comment thread rs/system_api/src/lib.rs Outdated
mraszyk
mraszyk reviewed Feb 24, 2025
View reviewed changes
Comment thread rs/test_utilities/execution_environment/src/lib.rs Outdated
mraszyk
mraszyk reviewed Feb 24, 2025
View reviewed changes
Comment thread rs/execution_environment/tests/hypervisor.rs Outdated
@michael-weigelt michael-weigelt added this pull request to the merge queue Feb 24, 2025
Merged via the queue into master with commit d193e26 Feb 24, 2025
@michael-weigelt michael-weigelt deleted the mwe/costs branch February 24, 2025 20:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@mraszyk mraszyk mraszyk left review comments

@eichhorl eichhorl eichhorl approved these changes

@schneiderstefan schneiderstefan schneiderstefan approved these changes

+1 more reviewer

@dragoljub-djuric dragoljub-djuric dragoljub-djuric approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

CI_ALL_BAZEL_TARGETS Runs all bazel targets @execution feat

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@michael-weigelt @dragoljub-djuric @schneiderstefan @mraszyk @eichhorl