Validate forwarded-property constraint in mock scope mapping#224
Merged
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #224 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 40 40
Lines 6128 6143 +15
=========================================
+ Hits 6128 6143 +15
🚀 New features to boost your workflow:
|
3a40278 to
c33e19b
Compare
Mock generation skipped the instantiableHasForwardedProperty check for non-root types with generateMock: true. A constant @Instantiated child with @forwarded properties would silently produce uncompilable mock code instead of a clear error. Extracted validateNoForwardedProperties(for:instantiable:parent:) as a shared helper called by both the production scope population loop and the mock generation loop. The mock path runs validation per-type after module filtering, so only types this module generates mocks for are checked. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
c33e19b to
839fd27
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
generateMock: truethat constant-instantiate a child with@Forwardedproperties now produce a clear error instead of silently generating uncompilable mock codevalidateNoForwardedProperties(for:instantiable:parent:)as a shared helper used by both prod scope population and mock generation — no duplicated validation logicWhat changed
createTypeDescriptionToScopeMappingloop intovalidateNoForwardedProperties(for:instantiable:parent:)generateMockCodeloop, after module filteringmock_throwsError_whenNonRootInstantiatedPropertyHasForwardedArgumentTest plan
🤖 Generated with Claude Code