Merged
Conversation
Replace OrderedSet with Array and OrderedDictionary with Dictionary in the four SafeDICore files that used them. The ordered semantics were not load-bearing: cycle-detection stacks are small arrays, the topological sort derives its order from the source propertiesToGenerate array, and the set subtraction in Initializer is a simple filter. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #218 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 40 40
Lines 6127 6128 +1
=========================================
+ Hits 6127 6128 +1
🚀 New features to boost your workflow:
|
Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
This function was added by #220 on main after the original PR branch diverged, so it retained OrderedSet references that the auto-merge did not convert. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
OrderedSetwithArrayandOrderedDictionarywithDictionaryacross 4 SafeDICore filesswift-collectionsfromPackage.swiftdependencies andPackage.resolvedpropertiesToGeneratearray, and the set subtraction inInitializeris a simple filterTest plan
🤖 Generated with Claude Code