Accept fulfillingAdditionalTypes as valid mock return types in macro#215
Merged
Accept fulfillingAdditionalTypes as valid mock return types in macro#215
Conversation
The macro's return type validation now checks additionalInstantiables in both the concrete and extension branches, matching the generator's behavior. Previously only the generator accepted additional types, causing the macro to emit an incorrect return type error. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
88ad9c3 to
1f8f185
Compare
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #215 +/- ##
=======================================
Coverage 99.94% 99.94%
=======================================
Files 40 40
Lines 5648 5652 +4
=======================================
+ Hits 5645 5649 +4
Misses 3 3
🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes a bug where the
@Instantiablemacro rejectedmock()methods returning a type fromfulfillingAdditionalTypes. The generator already handled this correctly (#213), but the macro validation did not checkadditionalInstantiables, causing a build error for adopters.Both the concrete and extension branches now check
additionalInstantiableswhen validating mock return types.Test plan
mockMethodReturningFulfillingAdditionalTypeProducesNoDiagnostic— concrete type withmock() -> MyServiceProtocolextension_mockMethodReturningFulfillingAdditionalTypeProducesNoDiagnostic— extension withmock() -> MyServiceProtocol🤖 Generated with Claude Code