Skip to content

fix: Temporarily removes snapcraft release code#99

Merged
serukii merged 2 commits intomainfrom
dj-wip
Oct 25, 2022
Merged

fix: Temporarily removes snapcraft release code#99
serukii merged 2 commits intomainfrom
dj-wip

Conversation

@djschleen
Copy link
Member

closes #96
closed #98

@djschleen djschleen added the bug Something isn't working label Oct 20, 2022
@djschleen djschleen added this to the 2.4.3 milestone Oct 20, 2022
@djschleen djschleen requested a review from a team as a code owner October 20, 2022 19:42
@djschleen djschleen self-assigned this Oct 20, 2022
@codecov
Copy link

codecov bot commented Oct 20, 2022

Codecov Report

Base: 83.85% // Head: 83.85% // No change to project coverage 👍

Coverage data is based on head (2102825) compared to base (9f17c33).
Patch coverage: 100.00% of modified lines in pull request are covered.

Additional details and impacted files
@@           Coverage Diff           @@
##             main      #99   +/-   ##
=======================================
  Coverage   83.85%   83.85%           
=======================================
  Files           7        7           
  Lines         322      322           
=======================================
  Hits          270      270           
  Misses         29       29           
  Partials       23       23           
Impacted Files Coverage Δ
lib/hookwriter.go 84.75% <100.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@djschleen djschleen added the enhancement New feature or request label Oct 20, 2022
Copy link

@serukii serukii left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice work dude :)

@serukii serukii merged commit f567f72 into main Oct 25, 2022
@serukii serukii deleted the dj-wip branch October 25, 2022 00:27
@djschleen djschleen modified the milestones: 2.4.3, 2.4.2 Oct 25, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working enhancement New feature or request

Development

Successfully merging this pull request may close these issues.

Create windows binary on release brew install returning a 404

2 participants