fix(ui-react): make package safe for Next.js #2491
Merged
+70
−15
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…r parameter handling
…-react/nextjs-copatibility-error
🦋 Changeset detectedLatest commit: b3af308 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
…ladinoBorges/devopness into fix/ui-react/nextjs-copatibility-error
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of changes
Guard top-level web-component registration and prevent server-side DOM access so the
@devopness/ui-reactpackage can be safely imported during Next.js (16.0.8, App Router) rendering and build-time evaluation.use clientwhere appropriate to keep them out of server bundles and ensure runtime-only APIs execute only in the browser;sideEffects: falseinpackage.jsonto avoid bundling side-effectful modules into server builds;GitHub issues resolved by this PR
Quality Assurance
packages/ui/reactand verify TypeScript and bundle outputs complete successfully;npm packand ensure a tarball is produced (devopness-ui-react-*.tgz);bun link) intodevopness-web-appand start the Next.js dev server. Confirm the app imports@devopness/ui-reactwithoutcannot read property of undefined (reading 'ReactCurrentDispatecher')or other SSR DOM-related errors;More info
Identified Error (using the package with NextJS 16.0.8)