fix(ui-react): implements resize observer to stop "Maximum update depth exceeded" in Tooltip #2473
+53
−52
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…r parameter handling
…-react/tooltip-maximum-update-depth-exceeded-error
…-react/tooltip-maximum-update-depth-exceeded-error
🦋 Changeset detectedLatest commit: 0e2df0d The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
…r' of github.com:AladinoBorges/devopness into fix/ui-react/tooltip-maximum-update-depth-exceeded-error
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of changes
This pull request contains a single, isolated fix for a runtime infinite-update loop that manifested as the React error "Maximum update depth exceeded". The problem was caused by an effect that could call
setStaterepeatedly when measurements changed (resize/overflow). The change adds a shallow-equality guard so the state only updates when the computed value actually differs, preventing repeated re-renders.packages/ui/react/src/components/Primitives/Tooltip/Tooltip.tsx: add guarded state update in overflow/resize effect to avoid redundantsetStatecalls, preventing infinite loop.GitHub issues resolved by this PR
Quality Assurance
packages/ui/reactbuilds successfully (TypeScript and bundle build complete).Tooltipcomponent pass locally.More info
Identified Error (using the package with NextJS)