-
Notifications
You must be signed in to change notification settings - Fork 132
fix(ui-react): stop forwarding styled-components styling props to DOM (grouped fixes) #2467
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
jfoliveira
merged 22 commits into
devopness:main
from
AladinoBorges:fix/ui-react/styled-components-transient-props
Dec 27, 2025
Merged
fix(ui-react): stop forwarding styled-components styling props to DOM (grouped fixes) #2467
jfoliveira
merged 22 commits into
devopness:main
from
AladinoBorges:fix/ui-react/styled-components-transient-props
Dec 27, 2025
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…r parameter handling
🦋 Changeset detectedLatest commit: d9e54c4 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
jfoliveira
approved these changes
Dec 27, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of changes
This pull request removes React "unknown prop" warnings by preventing styling-only props from being forwarded to native DOM elements. We migrated several styled-component props to use styled-components' transient prop pattern (prefix
$) and stopped spreading internal styling props into DOM-rendered elements.These changes are grouped together to reduce the number of pull requests and ensure the test and build outputs no longer contain React unknown-prop warnings for the updated components.
Pagination,EmptyData,Review,Loader,LoadStarship,Popover,Cover,Container,FormText,Alert.hideFirstAndLastButton→$hideFirstAndLastButton,isSmallContainer→$isSmallContainer,paddingTop→$paddingTop,isAlignLeft→$isAlignLeft,backgroundColor→$backgroundColor,shouldRemoveTopMargin→$shouldRemoveTopMargin,subTitleColor→$subtitleColor,noPadding→$noPadding,fullWidth→$fullWidth.GitHub issues resolved by this PR
Quality Assurance
packages/ui/reactbuilds successfully (TypeScript and bundle build complete);packages/ui/react;React does not recognize the <prop> propwarnings appear in test output for the components modified in this pull request (Pagination, EmptyData, Review, Loader, LoadStarship, Popover, Cover, Container, FormText, Alert).More info
Before
After