Skip to content

Conversation

@AladinoBorges
Copy link
Contributor

@AladinoBorges AladinoBorges commented Dec 27, 2025

Description of changes

This pull request removes React "unknown prop" warnings by preventing styling-only props from being forwarded to native DOM elements. We migrated several styled-component props to use styled-components' transient prop pattern (prefix $) and stopped spreading internal styling props into DOM-rendered elements.

These changes are grouped together to reduce the number of pull requests and ensure the test and build outputs no longer contain React unknown-prop warnings for the updated components.

  • Converted several primitives and form components to transient props to eliminate test-time warnings:
    • Pagination,
    • EmptyData,
    • Review,
    • Loader,
    • LoadStarship,
    • Popover,
    • Cover,
    • Container,
    • FormText,
    • Alert.
  • Examples of prop renames:
    • hideFirstAndLastButton$hideFirstAndLastButton,
    • isSmallContainer$isSmallContainer,
    • paddingTop$paddingTop,
    • isAlignLeft$isAlignLeft,
    • backgroundColor$backgroundColor,
    • shouldRemoveTopMargin$shouldRemoveTopMargin,
    • subTitleColor$subtitleColor,
    • noPadding$noPadding,
    • fullWidth$fullWidth.

GitHub issues resolved by this PR

  • N/A

Quality Assurance

  • Once the changes in this PR are merged and deployed, success criteria is:
    • Build: packages/ui/react builds successfully (TypeScript and bundle build complete);
    • Tests: All unit tests pass for packages/ui/react;
    • No React warnings for updated components: Verified no React does not recognize the <prop> prop warnings appear in test output for the components modified in this pull request (Pagination, EmptyData, Review, Loader, LoadStarship, Popover, Cover, Container, FormText, Alert).

More info

Before

Screenshot from 2025-12-26 17-43-41 Screenshot from 2025-12-26 17-43-26 Screenshot from 2025-12-26 17-42-42

After

Screenshot from 2025-12-27 11-13-56 Screenshot from 2025-12-27 11-14-03

@changeset-bot
Copy link

changeset-bot bot commented Dec 27, 2025

🦋 Changeset detected

Latest commit: d9e54c4

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@devopness/ui-react Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@jfoliveira jfoliveira merged commit b3a064d into devopness:main Dec 27, 2025
21 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants