Store alignment of .tdata as read-only variable#6
Merged
fincs merged 2 commits intodevkitPro:masterfrom Sep 14, 2022
Merged
Conversation
Also ensure __tls_start alignment matches that of .tdata, and use a minimum align of 8 for the 8-byte ARM TLS header.
Member
|
The main requested changes are in the corresponding libctru PR. As a minor nitpick, the tdata section doesn't really need 8-byte alignment as an enforced baseline. Like I explained in the corresponding PR, this 8-byte alignment is only required by the stack bottom and stack top addresses. It should be possible to adjust the logic in the other PR to make this guarantee without necessarily making it cascade into the tdata section's alignment. |
Set __tls_start such that (__tls_start - 8) is has the same alignment as .tdata.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Also ensure __tls_start alignment matches that of .tdata, and use a
minimum align of 8 for the 8-byte ARM TLS header.
This is part of the solution to devkitPro/libctru#497 and an accompanying PR will be opened there.