Skip to content

Created script that will upgrade devicon.json so that objects have the attribute "color" and "aliases" #279

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
Thomas-Boi wants to merge 3 commits into from
Closed

Created script that will upgrade devicon.json so that objects have the attribute "color" and "aliases" #279

Thomas-Boi wants to merge 3 commits into from

Conversation

@Thomas-Boi
Copy link
Member

@Thomas-Boi Thomas-Boi commented Sep 2, 2020 •
edited
Loading

Hey guys,

So this branch contains the scripts needed to upgrade the devicon.json.

To Run

Open a terminal and go to the root directory of the project. Enter node ./upgradeDeviconJson.js and the script will be run.

Note

  • This branch has been rebased over the most recent master branch.
  • Currently, the script will write its output to a file called newDevicon.json in the root directory. This is done so that the original copy doesn't get modified.
  • There will be log message about 4 fonts not having colors: clojure, clojurescript, yunohost, and redux. The script will then show you their object's attribute. As you can see, they don't have any font version for them. Since there are no font, there's no corresponding classes in the devicon.css and no colored classes in the devicon-colors.css.
    • We don't have to worry about this for now. To fix this issue, all we have to do is enter some font versions in the font attribute of each font then run the build script.
  • There's a commit where I renamed anything dot-net related to dotnet. This was done so that the folder has the same naming convention as everything else.

Feel free to checkout the script, it's in upgradeDeviconJson.js. I tried to have as much docs as possible but if you have any questions, feel free to reach out.

As always, feedback and suggestions are welcomed.

@Thomas-Boi Thomas-Boi force-pushed the upgrade-devicon branch 3 times, most recently from 16dffea to bd9de59 Compare September 2, 2020 01:51
@amacado amacado self-requested a review September 5, 2020 22:23
amacado
amacado requested changes Sep 5, 2020
View reviewed changes
Copy link
Member

@amacado amacado left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There's a commit where I renamed anything dot-net related to dotnet. This was done so that the folder has the same naming convention as everything else.

I would approve renaming dot-net to follow our conventions, but this would break compatibility. If we want to rename it, I would suggest to provide an alias to make the old version still work.

@amacado amacado mentioned this pull request Sep 6, 2020
Merged
@Thomas-Boi
Copy link
Member Author

Thomas-Boi commented Sep 7, 2020

Hey amacado,

Please don't merge this branch yet. I'm planning to revert the changes done to dotnet and mocha. I've found a few other fonts that have issues (clojure, redux...etc). I'm thinking that it's better to fix these errors in a later commit/merge. This commit should only focus on the new devicon.json. I think I might also work on the css gulp task and put it in this branch as well.

@Thomas-Boi Thomas-Boi closed this Sep 7, 2020
@amacado
Copy link
Member

amacado commented Sep 7, 2020 •
edited
Loading

Hey amacado,

Please don't merge this branch yet. I'm planning to revert the changes done to dotnet and mocha. I've found a few other fonts that have issues (clojure, redux...etc). I'm thinking that it's better to fix these errors in a later commit/merge. This commit should only focus on the new devicon.json.

Good idea to keep things seperated. Speaking of icons/fonts with 'errors' you can take a look at #248. I have written down what I already found. Feel free to comment on this issue.

I think I might also work on the css gulp task and put it in this branch as well.

There is no need to work on the gulp task, I already did it in e6a5f9c which you merged in #281. Or do you have something else in mind?

@amacado
Copy link
Member

amacado commented Sep 7, 2020

@Thomas-Boi Can we delete the branch upgrade-devicon and you work on it in your own fork? The less branches we have in this repository the better it is to maintain.

@Thomas-Boi Thomas-Boi deleted the upgrade-devicon branch September 7, 2020 17:41
@Thomas-Boi
Copy link
Member Author

Thomas-Boi commented Sep 7, 2020

There is no need to work on the gulp task, I already did it in e6a5f9c which you merged in #281. Or do you have something else in mind?

The gulp task that we have currently relies on the css files staying in the repo. I think that we want to create a system where the css files are generated in memory by gulp using the devicon.json. It'd just be an extra step for the gulp default.

Can we delete the branch upgrade-devicon and you work on it in your own fork? The less branches we have in this repository the better it is to maintain.

Sure, I'll delete the build-integrate branch as well

@amacado
Copy link
Member

amacado commented Sep 8, 2020

The gulp task that we have currently relies on the css files staying in the repo. I think that we want to create a system where the css files are generated in memory by gulp using the devicon.json. It'd just be an extra step for the gulp default.

True, I just wanted to say that we are able to publish this version as a first version of a working build automatisation (including the gulp task generating the *.min.css). Even when our "final" goal of having a single devicon.json is not achieved yet (next version of our build automatisation). :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@amacado amacado amacado requested changes

Assignees

No one assigned

Labels

enhancement

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@Thomas-Boi @amacado