Skip to content

new icon: firebird (original, plain) #2313

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
canaleal merged 12 commits into from
Dec 26, 2024
Merged

new icon: firebird (original, plain) #2313

canaleal merged 12 commits into from
Dec 26, 2024

Conversation

@Bulani
Copy link
Contributor

@Bulani Bulani commented Dec 10, 2024

Double check these details before you open a PR

  • PR does not match another non-stale PR currently opened
  • PR name matches the format new icon: Icon name (versions separated by comma). More details here
  • PR's base is the develop branch.
  • Your icons are inside a folder as seen here
  • SVG matches the standards laid out here
  • A new object is added in the devicon.json file at the correct alphabetic position as seen here

This PR closes NONE

Link to prove your SVG is correct and up-to-date.

https://www.firebirdsql.org/en/logos/

@Snailedlt Snailedlt changed the title Add new icon: firebird (original, plain) new icon: firebird (original, plain) Dec 11, 2024
@Snailedlt Snailedlt requested review from a team, ConX, Snailedlt, canaleal, lunatic-fox and weh and removed request for a team December 11, 2024 18:07
@Snailedlt Snailedlt added the feature:icon PR when a new icon is ready to be added to the collection label Dec 11, 2024
canaleal
canaleal reviewed Dec 22, 2024
View reviewed changes
Copy link
Member

@canaleal canaleal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thankyou for your contribution! Ive added some comments on what needs to be changed. If you need any help feel free to ask.

@Bulani
Copy link
Contributor Author

Bulani commented Dec 23, 2024

@canaleal I resolveded the problems in icons

canaleal
canaleal approved these changes Dec 26, 2024
View reviewed changes
Copy link
Member

@canaleal canaleal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I scaled up the SVGs to have a viewbox of 128x128.

There are no artifacts in the SVGs.

image

@github-actions
Copy link
Contributor

github-actions bot commented Dec 26, 2024

Hi!

I'm the check-bot and we have some issues with your PR:

devicon.json is not sorted correctly.
Please make sure that your icon is added in the `devicon.json` file at the correct alphabetic position
as seen here: https://github.com/devicons/devicon/wiki/Updating-%60devicon.json%60

Check our CONTRIBUTING guide for more details regarding these errors.

Please address these issues. When you update this PR, I will check your SVGs again.

Thanks for your help,
SVG-Checker Bot 😄

@canaleal canaleal merged commit 8c64cd4 into devicons:develop Dec 26, 2024
5 checks passed
@canaleal canaleal mentioned this pull request Jun 30, 2025
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@canaleal canaleal canaleal approved these changes

@ConX ConX Awaiting requested review from ConX ConX was automatically assigned from devicons/devicon__reviewers

@weh weh Awaiting requested review from weh weh was automatically assigned from devicons/devicon__reviewers

@Snailedlt Snailedlt Awaiting requested review from Snailedlt Snailedlt was automatically assigned from devicons/devicon__reviewers

@lunatic-fox lunatic-fox Awaiting requested review from lunatic-fox lunatic-fox was automatically assigned from devicons/devicon__reviewers

Assignees

No one assigned

Labels

feature:icon PR when a new icon is ready to be added to the collection

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@Bulani @canaleal @Snailedlt