Skip to content

new icon: visualbasic (original, plain) #1871

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
Helder-Machava wants to merge 3 commits into from
Closed

new icon: visualbasic (original, plain) #1871

Helder-Machava wants to merge 3 commits into from

Conversation

@Helder-Machava
Copy link
Contributor

@Helder-Machava Helder-Machava commented Sep 15, 2023 •
edited by Snailedlt
Loading

Double check these details before you open a PR

  • PR does not match another non-stale PR currently opened
  • PR name matches the format new icon: Icon name (versions separated by comma). More details here
  • PR's base is the develop branch.
  • Your icons are inside a folder as seen here
  • SVG matches the standards laid out here
  • A new object is added in the devicon.json file as seen here

This PR closes #910

Link to prove your SVG is correct and up-to-date.

@Helder-Machava
Copy link
Contributor Author

Helder-Machava commented Sep 20, 2023

Does it take to much time 😞🤔 to review the PR?

@canaleal canaleal mentioned this pull request Oct 4, 2023
Closed
6 tasks
Snailedlt
Snailedlt requested changes Oct 21, 2023
View reviewed changes
Copy link
Collaborator

@Snailedlt Snailedlt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for the contribution!
In addition to the suggested changes, could you please provide a link to the official website and logo?

@Snailedlt Snailedlt added the feature:icon PR when a new icon is ready to be added to the collection label Oct 30, 2023
@lunatic-fox lunatic-fox changed the title new icon: visualbasic new icon: visualbasic (original, plain) Nov 5, 2023
lunatic-fox
lunatic-fox reviewed Nov 5, 2023
View reviewed changes
Copy link
Contributor

@lunatic-fox lunatic-fox left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Icons based on: https://raw.githubusercontent.com/dotnet/docs/cb475ed45f881e9462e34764480d3b0ebce85e91/docs/images/hub/vb.svg

Seems that the previous icon was based in the old Visual Studio logo, but now everything seems to be fine. 🔧

@lunatic-fox lunatic-fox requested a review from Snailedlt November 5, 2023 19:33
@Helder-Machava Helder-Machava deleted the develop branch November 7, 2023 05:26
@Snailedlt Snailedlt requested review from a team, ConX, canaleal, lunatic-fox and weh and removed request for a team December 6, 2023 15:05
Snailedlt
Snailedlt reviewed Dec 6, 2023
View reviewed changes
Copy link
Collaborator

@Snailedlt Snailedlt left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not sure why this PR got closed and the branch deleted, but it looks good now. Only thing missing is a fill color for the plain version

icons/visualbasic/visualbasic-plain.svg
@@ -0,0 +1 @@
<svg xmlns="http://www.w3.org/2000/svg" viewBox="0 0 128 128"><path d="M64 0A64 64 0 000 64a64 64 0 0064 64 64 64 0 0064-64A64 64 0 0064 0zm-3.76 38.7l6.34.1L48 89.202h-6.58L23.14 38.8h6.579l14 40a23.74 23.74 0 011.02 4.46h.141a22 22 0 011.119-4.56zm13.6.1h14.34A15.68 15.68 0 0198.54 42a10.34 10.34 0 013.84 8.34 12.26 12.26 0 01-2.38 7.44 12.52 12.52 0 01-6.4 4.501v.139a12.82 12.82 0 018.16 3.84 11.84 11.84 0 013.06 8.461 13.18 13.18 0 01-4.64 10.48 17.28 17.28 0 01-11.7 4H73.84zm12.7 5.26l-6.7.06V60.4h5.999a11.48 11.48 0 007.58-2.4 8.14 8.14 0 002.781-6.6c0-4.893-3.22-7.34-9.66-7.34zm-6.7 21.641v18.14h8a12 12 0 008-2.46 8.42 8.42 0 002.86-6.74c0-5.947-4.053-8.92-12.16-8.92z"/></svg>
Copy link
Collaborator

@Snailedlt Snailedlt Dec 6, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
<svg xmlns="http://www.w3.org/2000/svg" viewBox="0 0 128 128"><path d="M64 0A64 64 0 000 64a64 64 0 0064 64 64 64 0 0064-64A64 64 0 0064 0zm-3.76 38.7l6.34.1L48 89.202h-6.58L23.14 38.8h6.579l14 40a23.74 23.74 0 011.02 4.46h.141a22 22 0 011.119-4.56zm13.6.1h14.34A15.68 15.68 0 0198.54 42a10.34 10.34 0 013.84 8.34 12.26 12.26 0 01-2.38 7.44 12.52 12.52 0 01-6.4 4.501v.139a12.82 12.82 0 018.16 3.84 11.84 11.84 0 013.06 8.461 13.18 13.18 0 01-4.64 10.48 17.28 17.28 0 01-11.7 4H73.84zm12.7 5.26l-6.7.06V60.4h5.999a11.48 11.48 0 007.58-2.4 8.14 8.14 0 002.781-6.6c0-4.893-3.22-7.34-9.66-7.34zm-6.7 21.641v18.14h8a12 12 0 008-2.46 8.42 8.42 0 002.86-6.74c0-5.947-4.053-8.92-12.16-8.92z"/></svg>
<svg xmlns="http://www.w3.org/2000/svg" viewBox="0 0 128 128"><path fill="#004e8c" d="M64 0A64 64 0 000 64a64 64 0 0064 64 64 64 0 0064-64A64 64 0 0064 0zm-3.76 38.7l6.34.1L48 89.202h-6.58L23.14 38.8h6.579l14 40a23.74 23.74 0 011.02 4.46h.141a22 22 0 011.119-4.56zm13.6.1h14.34A15.68 15.68 0 0198.54 42a10.34 10.34 0 013.84 8.34 12.26 12.26 0 01-2.38 7.44 12.52 12.52 0 01-6.4 4.501v.139a12.82 12.82 0 018.16 3.84 11.84 11.84 0 013.06 8.461 13.18 13.18 0 01-4.64 10.48 17.28 17.28 0 01-11.7 4H73.84zm12.7 5.26l-6.7.06V60.4h5.999a11.48 11.48 0 007.58-2.4 8.14 8.14 0 002.781-6.6c0-4.893-3.22-7.34-9.66-7.34zm-6.7 21.641v18.14h8a12 12 0 008-2.46 8.42 8.42 0 002.86-6.74c0-5.947-4.053-8.92-12.16-8.92z"/></svg>

@Snailedlt
Copy link
Collaborator

Snailedlt commented Dec 6, 2023

Seems like we'll need to recreate this branch, since it's been deleted, and thus we cannot reopen the PR

@Snailedlt Snailedlt mentioned this pull request Dec 6, 2023
Merged
6 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Snailedlt Snailedlt Snailedlt requested changes

@ConX ConX Awaiting requested review from ConX ConX was automatically assigned from devicons/devicon__reviewers

@weh weh Awaiting requested review from weh weh was automatically assigned from devicons/devicon__reviewers

@canaleal canaleal Awaiting requested review from canaleal canaleal was automatically assigned from devicons/devicon__reviewers

@lunatic-fox lunatic-fox Awaiting requested review from lunatic-fox lunatic-fox was automatically assigned from devicons/devicon__reviewers

+1 more reviewer

@PrasannaBrabourame PrasannaBrabourame PrasannaBrabourame approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

feature:icon PR when a new icon is ready to be added to the collection

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@Helder-Machava @Snailedlt @PrasannaBrabourame @lunatic-fox