Skip to content

Discussion on how/when to merge fonts into the master branch #287

@Thomas-Boi

Description

@Thomas-Boi

Hey @amacado,

I think that we should discuss on how we are going to merge fonts into the master branch from now on. Now that we have the build system, we can do batch updates instead of single changes. However, this means that we might have conflicts when merging or we might repeat fonts already added.

Perhaps we should create another readme for merging rules. This would be useful for future collaborators who would like to help us out. Beside that, we also need to work out a way to communicate who's merging which font/PR.

For the readme, it should list out things like:

  • How to add new icons to the devicon.json
  • What to do before pushing the changes: make sure files are in the icons folder
  • Possible issue (the task failing for the first couple times but work if you re-run it)

For the communication over which who's doing which PR/fonts, I think that we can use the GitHub Projects tab. I created an example board that you can check out and try. We can customize this to address issues as well.

Let me know what you think :)

Metadata

Metadata

Assignees

No one assigned

    Labels

    discussionCommunity discussions about changes/features/..questionGeneral questions not covered by another label

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions