feature: use env! macro to throw error's at compile time.#441
feature: use env! macro to throw error's at compile time.#441skeptrunedev merged 1 commit intodevflowinc:mainfrom tobihans:feat/env-macro
Conversation
|
Closing this as @anikdhabal has a more complete version live. Make sure to star the repo!!! |
|
I see. I saw his own has a lot of mistakes essentially related to Rust syntax. That's the only reason I continued, otherwise I would have closed it myself. And in case you didn't remark, that was a draft, pending when I finish Thanks. |
|
Thanks, I'm in the process of solving the merge conflict now. |
You actually make quite a good point 😅. I closed this before I really reviewed the other claim. It's a long ways off being correct honestly. Reopened. We will merge and reward the first PR that accurately resolves the issue. In the future we will make a policy for this so it doesn't happen again. |
|
@skeptrunedev It's fine now. I extended it to load the env from the build script as you suggested in the other PR. Thanks |
I guess that was AI-generated. |
No lol. Assuming this compiles and it works, it was done first so will be the PR merged. Just 2am for me. Going to sleep and will review and merge when I wake up. |
Pls show me the snapshot after generating the output of this issue,I am also curious to see if it matches with my code or not. Reopening the issue doesn't mean you should talk about anything or anyone's PR. @skeptrunedev look into this. |
|
Closed my PR. I think your PR is more intuitive. |
Sorry about that @anikdhabal |
|
Made a few final changes so the .env.dist's had the correct data, squashed, and added a proper commit message. It is all good now. Great work! |

This PR closes #246.
/claim #246