Skip to content

feature: use env! macro to throw error's at compile time.#441

Merged
skeptrunedev merged 1 commit intodevflowinc:mainfrom
tobihans:feat/env-macro
Sep 19, 2023
Merged

feature: use env! macro to throw error's at compile time.#441
skeptrunedev merged 1 commit intodevflowinc:mainfrom
tobihans:feat/env-macro

Conversation

@tobihans
Copy link
Copy Markdown
Contributor

@tobihans tobihans commented Sep 18, 2023

This PR closes #246.
/claim #246

@skeptrunedev
Copy link
Copy Markdown
Contributor

Closing this as @anikdhabal has a more complete version live.

Make sure to star the repo!!!

@tobihans
Copy link
Copy Markdown
Contributor Author

tobihans commented Sep 19, 2023

I see. I saw his own has a lot of mistakes essentially related to Rust syntax. That's the only reason I continued, otherwise I would have closed it myself. And in case you didn't remark, that was a draft, pending when I finish Thanks.

@skeptrunedev skeptrunedev reopened this Sep 19, 2023
@tobihans
Copy link
Copy Markdown
Contributor Author

Thanks, I'm in the process of solving the merge conflict now.

@skeptrunedev
Copy link
Copy Markdown
Contributor

I see. I saw his own has a lot of mistakes essentially related to Rust syntax. That's the only reason I continued, otherwise I would have closed it myself. Thanks.

You actually make quite a good point 😅.

I closed this before I really reviewed the other claim. It's a long ways off being correct honestly.

Reopened. We will merge and reward the first PR that accurately resolves the issue.

In the future we will make a policy for this so it doesn't happen again.

@tobihans tobihans marked this pull request as ready for review September 19, 2023 06:58
@tobihans
Copy link
Copy Markdown
Contributor Author

@skeptrunedev It's fine now. I extended it to load the env from the build script as you suggested in the other PR. Thanks

@tobihans
Copy link
Copy Markdown
Contributor Author

I closed this before I really reviewed the other claim. It's a long ways off being correct honestly.
In the future we will make a policy for this so it doesn't happen again.

I guess that was AI-generated.

@skeptrunedev
Copy link
Copy Markdown
Contributor

skeptrunedev commented Sep 19, 2023

I closed this before I really reviewed the other claim. It's a long ways off being correct honestly.
In the future we will make a policy for this so it doesn't happen again.

I guess that was AI-generated.

No lol. Assuming this compiles and it works, it was done first so will be the PR merged. Just 2am for me. Going to sleep and will review and merge when I wake up.

@anikdhabal
Copy link
Copy Markdown
Contributor

I closed this before I really reviewed the other claim. It's a long ways off being correct honestly.
In the future we will make a policy for this so it doesn't happen again.

I guess that was AI-generated.

Pls show me the snapshot after generating the output of this issue,I am also curious to see if it matches with my code or not. Reopening the issue doesn't mean you should talk about anything or anyone's PR. @skeptrunedev look into this.

@anikdhabal
Copy link
Copy Markdown
Contributor

Closed my PR. I think your PR is more intuitive.

@tobihans
Copy link
Copy Markdown
Contributor Author

tobihans commented Sep 19, 2023

I closed this before I really reviewed the other claim. It's a long ways off being correct honestly.
In the future we will make a policy for this so it doesn't happen again.

I guess that was AI-generated.

Pls show me the snapshot after generating the output of this issue,I am also curious to see if it matches with my code or not. Reopening the issue doesn't mean you should talk about anything or anyone's PR. @skeptrunedev look into this.

Sorry about that @anikdhabal

@skeptrunedev
Copy link
Copy Markdown
Contributor

Made a few final changes so the .env.dist's had the correct data, squashed, and added a proper commit message.

It is all good now. Great work!

@skeptrunedev
Copy link
Copy Markdown
Contributor

And star the repo if you have not yet!

image

@skeptrunedev skeptrunedev merged commit 5a32a6a into devflowinc:main Sep 19, 2023
@tobihans tobihans deleted the feat/env-macro branch September 19, 2023 21:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

feature: use env! macro to throw error's at compile time.

3 participants