Switch k8s apiVersion to v1alpha2#125
Merged
amisevsk merged 1 commit intodevfile:masterfrom Aug 26, 2020
Merged
Conversation
Switch devworkspace API to v1alpha2 to allow for breaking changes from v1alpha1. Signed-off-by: Angel Misevski <amisevsk@redhat.com>
32d14f9 to
47ca42e
Compare
davidfestal
approved these changes
Aug 26, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Switch CRD version to
v1alpha2.v1alpha2CRDs are not meant to be deployed yet as their spec is not necessarily fixed. Thepkg/apiscan continue to be used, and should be compatible by switching imports fromv1alpha1tov1alpha2What issues does this PR fix or reference?
Fixes #111
Is your PR tested? Consider putting some instruction how to test your changes
./build.shcompletes successfully