Skip to content

Amazonia-1 pipeline initial implementation#33

Merged
sharkinsspatial merged 7 commits intodevelopmentseed:mainfrom
fredliporace:amz1
Jun 28, 2023
Merged

Amazonia-1 pipeline initial implementation#33
sharkinsspatial merged 7 commits intodevelopmentseed:mainfrom
fredliporace:amz1

Conversation

@fredliporace
Copy link
Collaborator

What I am changing

  • Support for Amazonia-1 pipeline

How I did it

  • Built from sentinel1 template

How you can test it

  • (export PIPELINE="amazonia_1" && tox)

@sharkinsspatial
Copy link
Member

@fredliporace Apologies for the delay in reviewing this. I'll try to check over things today.

Copy link
Member

@sharkinsspatial sharkinsspatial left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@fredliporace I deployed this pipeline to our dev environment. The collection was created successfully

curl --location --request GET 'https://dev.asdi-catalog.org/collections/AMAZONIA1-WFI'

I'll monitor things to verify that the SNS topic subscription is working correctly and then merge this.

@@ -0,0 +1,3 @@
aws-lambda-powertools
jmespath
stactools-amazonia-1 >= 0.1.1
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@fredliporace Can you also include s3fs in the requirements as it is necessary when fsspec infers the s3 protocol when using use_fsspec.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done in 638779e

xml_key = xml_key_from_quicklook_key(png_key)
href = f"s3://{bucket}/{xml_key}"
print(href)
stac = create_item(asset_href=href)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@fredliporace I also created another new issue over on the stactools package regarding the hardcoded bucket prefix of cbers-pds.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Issue fixed.

from aws_asdi_pipelines.cognito.utils import get_token


def xml_key_from_quicklook_key(key: str) -> str:
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@fredliporace It looks like this function might need to be extended for some different cases of inferring the xml key. As an example looking at s3://amazonia-pds/AMAZONIA1/WFI/033/018/AMAZONIA_1_WFI_20230621_033_018_L4/.

The xml key is actually AMAZONIA_1_WFI_20230621_033_018_L4_LEFT_BAND2.xml rather than the key AMAZONIA_1_WFI_20230621_033_018_L4_BAND2.xml which the function produces.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@sharkinsspatial see #34, working on that.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@sharkinsspatial #34 is fixed by bdfe86c but my testing in actual aws environment is limited, let me know if any additional work is required.

@sharkinsspatial sharkinsspatial merged commit 8e306a1 into developmentseed:main Jun 28, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants