Skip to content

feat: Add support for geoarrow point layers #241

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
gadomski merged 4 commits into from
Jan 12, 2026
Merged

feat: Add support for geoarrow point layers #241

gadomski merged 4 commits into from
Jan 12, 2026
+130 −43

Conversation

@sandrahoang686
Copy link
Contributor

@sandrahoang686 sandrahoang686 commented Jan 5, 2026

Ticket: #179

Checklist

  • Code is formatted (yarn format)
  • Code is linted (yarn lint)
  • Code builds (yarn build)
  • Tests pass (yarn test)
  • Commit messages and/or this PR's title are formatted per Conventional Commits

gadomski
gadomski requested changes Jan 6, 2026
View reviewed changes
Copy link
Collaborator

@gadomski gadomski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In general, looks about right! Just one refactor on how we're passing information, and one thing I'm not sure about the upstream.

@sandrahoang686 sandrahoang686 mentioned this pull request Jan 7, 2026
Open
@sandrahoang686
Copy link
Contributor Author

sandrahoang686 commented Jan 7, 2026

stac-map-pr-241-zoom-bug.mov

@gadomski here is what this currently looks like for the points geometry type. I've been testing with parquet files from here. But I cant figure out the bug where when I zoom in - the points disappear? Would you happen to know how to fix that or what is going on there? i've tried different things but i'm not familiar enough.

Also related to #242 - I've left a comment there after taking a look 👍🏼

gadomski
gadomski reviewed Jan 7, 2026
View reviewed changes
@sandrahoang686 @gadomski
Update scatterplotplayer size attributues
295d9ab 
Co-authored-by: Pete Gadomski <pete.gadomski@gmail.com>
@sandrahoang686 sandrahoang686 changed the title feat: [WIP] Add support for geoarrow point layers feat: Add support for geoarrow point layers Jan 12, 2026
@sandrahoang686 sandrahoang686 marked this pull request as ready for review January 12, 2026 16:43
@sandrahoang686
Copy link
Contributor Author

sandrahoang686 commented Jan 12, 2026

@gadomski converted to PR and ready for review 🙇🏼‍♀️

gadomski
gadomski approved these changes Jan 12, 2026
View reviewed changes
Copy link
Collaborator

@gadomski gadomski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome, this is great @sandrahoang686!!!

@gadomski gadomski linked an issue Jan 12, 2026 that may be closed by this pull request
Support non-polygon geoparquet geometries #179
Open
@gadomski gadomski removed a link to an issue Jan 12, 2026
Support non-polygon geoparquet geometries #179
Open
@gadomski gadomski merged commit 3c1f02e into main Jan 12, 2026
6 checks passed
@gadomski gadomski deleted the support-non-polygon-geometries branch January 12, 2026 16:58
@gadomski gadomski mentioned this pull request Jan 12, 2026
Open
@github-actions
Copy link

github-actions bot commented Jan 12, 2026

🎉 This PR is included in version 0.12.0 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@gadomski gadomski gadomski approved these changes

Assignees

No one assigned

Labels

released

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@sandrahoang686 @gadomski