Use DI to prevent multiple copies of @babel/core by developit · Pull Request #664 · developit/microbundle

developit · 2020-06-19T17:03:14Z

Here's the difference:

This uses the copy of @babel/core that is being used to transform and run plugins:

export function custom(core) {
  return {
    config() {
      core.createConfigItem(...)
    }
  }
}

This uses the copy of @babel/core that npm installed for Microbundle, which may be different:

import core from '@babel/core';
export function custom() {
  return {
    config() {
      core.createConfigItem(...)
    }
  }
}

Fixes #657.

developit · 2020-06-19T17:18:58Z

I've manually tested this change in 2 broken projects and it works!

developit added 2 commits June 19, 2020 13:03

Use DI to prevent multiple copies of @babel/core

de9c164

Fixes #657.

Actually fix it (haha)

25496f9

developit requested review from ForsakenHarmony and wardpeet June 19, 2020 17:20

andrewiggins approved these changes Jun 19, 2020

View reviewed changes

developit merged commit 5f8ea9e into master Jun 19, 2020

developit deleted the babel-core-dupes branch June 19, 2020 17:27

Provide feedback